From: Christoph Hellwig <hch@lst•de>
To: Robin Murphy <robin.murphy@arm•com>
Cc: Gavin Li <git@thegavinli•com>, Shawn Guo <shawnguo@kernel•org>,
Fabio Estevam <festevam@gmail•com>,
Christoph Hellwig <hch@lst•de>,
linux-arch@vger•kernel.org,
Michal Simek <michal.simek@xilinx•com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>,
Alan Stern <stern@rowland•harvard.edu>,
NXP Linux Team <linux-imx@nxp•com>,
Mathias Nyman <mathias.nyman@intel•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Minas Harutyunyan <hminas@synopsys•com>,
Olav Kongas <ok@artecdesign•ee>, Bin Liu <b-liu@ti•com>,
linux-arm-kernel@lists•infradead.org,
Geoff Levand <geoff@infradead•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-usb@vger•kernel.org, linux-kernel@vger•kernel.org,
Tony Prisk <linux@prisktech•co.nz>,
iommu@lists•linux-foundation.org,
Pengutronix Kernel Team <kernel@pengutronix•de>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device
Date: Thu, 15 Aug 2019 15:32:04 +0200 [thread overview]
Message-ID: <20190815133204.GD12036@lst.de> (raw)
In-Reply-To: <fbea6e6d-7721-b51d-0501-582e8446e9c9@arm.com>
On Wed, Aug 14, 2019 at 04:49:13PM +0100, Robin Murphy wrote:
>> because we have to support platform_device structures that are
>> statically allocated.
>
> This would be a good point to also get rid of the long-standing bodge in
> platform_device_register_full().
platform_device_register_full looks odd to start with, especially
as the coumentation is rather lacking..
>> +static void setup_pdev_archdata(struct platform_device *pdev)
>
> Bikeshed: painting the generic DMA API properties as "archdata" feels a bit
> off-target :/
>
>> +{
>> + if (!pdev->dev.coherent_dma_mask)
>> + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
>> + if (!pdev->dma_mask)
>> + pdev->dma_mask = DMA_BIT_MASK(32);
>> + if (!pdev->dev.dma_mask)
>> + pdev->dev.dma_mask = &pdev->dma_mask;
>> + arch_setup_pdev_archdata(pdev);
>
> AFAICS m68k's implementation of that arch hook becomes entirely redundant
> after this change, so may as well go. That would just leave powerpc's
> actual archdata, which at a glance looks like it could probably be cleaned
> up with not *too* much trouble.
Actually I think we can just kill both off. At the point archdata
is indeed entirely misnamed.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-15 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-11 8:05 next take at setting up a dma mask by default for platform devices Christoph Hellwig
2019-08-11 8:05 ` [PATCH 1/6] usb: don't create dma pools for HCDs with a localmem_pool Christoph Hellwig
2019-08-11 8:05 ` [PATCH 2/6] usb: add a hcd_uses_dma helper Christoph Hellwig
2019-08-11 8:05 ` [PATCH 3/6] usb: add a HCD_DMA flag instead of guestimating DMA capabilities Christoph Hellwig
2019-08-12 11:57 ` Christoph Hellwig
2019-08-11 8:05 ` [PATCH 4/6] usb/max3421: remove the dummy {un, }map_urb_for_dma methods Christoph Hellwig
2019-08-11 8:05 ` [PATCH 5/6] dma-mapping: remove is_device_dma_capable Christoph Hellwig
2019-08-11 8:05 ` [PATCH 6/6] driver core: initialize a default DMA mask for platform device Christoph Hellwig
2019-08-14 15:49 ` Robin Murphy
2019-08-15 13:32 ` Christoph Hellwig [this message]
2019-08-15 13:03 ` Greg Kroah-Hartman
2019-08-15 13:38 ` Christoph Hellwig
2019-08-15 14:05 ` Greg Kroah-Hartman
2019-08-15 13:23 ` next take at setting up a dma mask by default for platform devices Greg Kroah-Hartman
2019-08-15 13:25 ` Christoph Hellwig
2019-08-15 14:05 ` Greg Kroah-Hartman
2019-08-15 14:39 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2019-08-16 6:24 next take at setting up a dma mask by default for platform devices v2 Christoph Hellwig
2019-08-16 6:24 ` [PATCH 6/6] driver core: initialize a default DMA mask for platform device Christoph Hellwig
2019-08-16 7:39 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815133204.GD12036@lst.de \
--to=hch@lst$(echo .)de \
--cc=b-liu@ti$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=geoff@infradead$(echo .)org \
--cc=git@thegavinli$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hminas@synopsys$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux@prisktech$(echo .)co.nz \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mathias.nyman@intel$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=ok@artecdesign$(echo .)ee \
--cc=robin.murphy@arm$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox