From: Guenter Roeck <linux@roeck-us•net>
To: Arnd Bergmann <arnd@arndb•de>
Cc: linux-hwmon@vger•kernel.org, linux-rtc@vger•kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
Jean Delvare <jdelvare@suse•com>,
Anatolij Gustschin <agust@denx•de>,
linux-um@lists•infradead.org, linux-kernel@vger•kernel.org,
Ludovic Desroches <ludovic.desroches@microchip•com>,
Florian Fainelli <f.fainelli@gmail•com>,
bcm-kernel-feedback-list@broadcom•com, viro@zeniv•linux.org.uk,
linux-fsdevel@vger•kernel.org,
openipmi-developer@lists•sourceforge.net,
Wim Van Sebroeck <wim@linux-watchdog•org>,
linuxppc-dev@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org,
linux-watchdog@vger•kernel.org
Subject: Re: [PATCH v5 06/18] compat_ioctl: move WDIOC handling into wdt drivers
Date: Thu, 15 Aug 2019 11:10:10 -0700 [thread overview]
Message-ID: <20190815181010.GA28580@roeck-us.net> (raw)
In-Reply-To: <20190814205245.121691-1-arnd@arndb.de>
On Wed, Aug 14, 2019 at 10:49:18PM +0200, Arnd Bergmann wrote:
> All watchdog drivers implement the same set of ioctl commands, and
> fortunately all of them are compatible between 32-bit and 64-bit
> architectures.
>
> Modern drivers always go through drivers/watchdog/wdt.c as an abstraction
> layer, but older ones implement their own file_operations on a character
> device for this.
>
> Move the handling from fs/compat_ioctl.c into the individual drivers.
>
> Note that most of the legacy drivers will never be used on 64-bit
> hardware, because they are for an old 32-bit SoC implementation, but
> doing them all at once is safer than trying to guess which ones do
> or do not need the compat_ioctl handling.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Reviewed-by: Guenter Roeck <linux@roeck-us•net>
This patch doesn't seem to have a useful base (or at least git says so).
It does not apply to mainline nor to my own watchdog-next branch.
I assume you plan to apply the entire series together. Please not
that there will be conflicts against watchdog-next when you do so.
Guenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-15 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190814204259.120942-1-arnd@arndb.de>
2019-08-14 20:49 ` [PATCH v5 06/18] compat_ioctl: move WDIOC handling into wdt drivers Arnd Bergmann
2019-08-15 18:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815181010.GA28580@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=agust@denx$(echo .)de \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ludovic.desroches@microchip$(echo .)com \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox