Subject: Re: [PATCH] bus: imx-weim: module_platform_driver()

From: Shawn Guo <[email-masked]>
Date: Mon, 19 Aug 2019 14:08:30 +0200

On Wed, Aug 14, 2019 at 10:23:16AM +0200, Sascha Hauer wrote:
> Switch from module_platform_driver_probe() to module_platform_driver().
> The former is not suitable for booting with device tree as the driver
> will be registered before the device and thus won't be probed again
> when the device is present.
> 
> Signed-off-by: Sascha Hauer <[email-masked]>

Applied with subject updated like below.

  bus: imx-weim: use module_platform_driver()

Shawn

> ---
>  drivers/bus/imx-weim.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index db74334ca5ef..8a9f8a4328c2 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -183,8 +183,7 @@ static int __init weim_timing_setup(struct device *dev,
>  	return 0;
>  }
>  
> -static int __init weim_parse_dt(struct platform_device *pdev,
> -				void __iomem *base)
> +static int weim_parse_dt(struct platform_device *pdev, void __iomem *base)
>  {
>  	const struct of_device_id *of_id = of_match_device(weim_id_table,
>  							   &pdev->dev);
> @@ -217,7 +216,7 @@ static int __init weim_parse_dt(struct platform_device *pdev,
>  	return ret;
>  }
>  
> -static int __init weim_probe(struct platform_device *pdev)
> +static int weim_probe(struct platform_device *pdev)
>  {
>  	struct resource *res;
>  	struct clk *clk;
> @@ -254,8 +253,9 @@ static struct platform_driver weim_driver = {
>  		.name		= "imx-weim",
>  		.of_match_table	= weim_id_table,
>  	},
> +	.probe = weim_probe,
>  };
> -module_platform_driver_probe(weim_driver, weim_probe);
> +module_platform_driver(weim_driver);
>  
>  MODULE_AUTHOR("Freescale Semiconductor Inc.");
>  MODULE_DESCRIPTION("i.MX EIM Controller Driver");
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel