Subject: Re: coresight: ACPI hook for funnel on ThunderX2

From: Mathieu Poirier <[email-masked]>
Date: Mon, 19 Aug 2019 14:06:40 -0600

Hi Tanmay,

On Thu, Aug 15, 2019 at 01:58:21PM +0000, Tanmay Vilas Kumar Jagdale wrote:
> Coresight topology on Marvell's ThunderX2 Processor is as follows:
> 
>  ETM0 _                                                   _ TPIU
>  ...   \    Static      Dynamic                          /
>  ...    --> FUNNEL0 --> FUNNEL1 --> ETF --> REPLICATOR --
> ETM127_/            |                                    \_ ETR
>                     |
>             ETM128--|
>                     /
>            Others--/
> 
> To support this topology add ACPI hook for Static Funnel0.
> 
> Signed-off-by: Tanmay Jagdale <[email-masked]>

There are a few things that aren't working with your patch.  First it doesn't
clear checkpatch.pl - a lot of maintainers will not even look at a patch when
it is the case.  Second it doesn't apply to my coresight next branch[1] and
third there are formatting issue with the subject line.

I suggest you peruse through the Documentation/process directory with a special
interest toward files submitting-patches.rst and submit-checklist.rst.  Your
life (and mine) will be greatly improved in the process. 

More comments below...

> ---
>  drivers/hwtracing/coresight/coresight-funnel.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c
> index fa97cb9ab4f9..315691fd6f4b 100644
> --- a/drivers/hwtracing/coresight/coresight-funnel.c
> +++ b/drivers/hwtracing/coresight/coresight-funnel.c
> @@ -5,6 +5,7 @@
>   * Description: CoreSight Funnel driver
>   */
>  
> +#include <linux/acpi.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> @@ -297,6 +298,11 @@ static int static_funnel_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> +static const struct acpi_device_id static_funnel_acpi_ids[] = {
> +	{ "CAV901A" },
> +	{},
> +};
> +

Is there anything different between this static funnel and ARM's static funnel?
An ACPI device for static funnels has already been added[2] - this is probably
what you should be using.

Thanks,
Mathieu

[1]. https://git.linaro.org/kernel/coresight.git/log/?h=next
[2]. 991de72831b3 coresight: acpi: Static funnel support

>  static const struct of_device_id static_funnel_match[] = {
>  	{.compatible = "arm,coresight-static-funnel"},
>  	{}
> @@ -306,6 +312,7 @@ static struct platform_driver static_funnel_driver = {
>  	.probe          = static_funnel_probe,
>  	.driver         = {
>  		.name   = "coresight-static-funnel",
> +		.acpi_match_table = ACPI_PTR(static_funnel_acpi_ids),
>  		.of_match_table = static_funnel_match,
>  		.pm	= &funnel_dev_pm_ops,
>  		.suppress_bind_attrs = true,
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel