From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Masahiro Yamada <yamada.masahiro@socionext•com>
Cc: linux-kernel@vger•kernel.org,
Ludovic Desroches <ludovic.desroches@microchip•com>,
linux-arm-kernel@lists•infradead.org,
Russell King <linux@armlinux•org.uk>
Subject: Re: [PATCH] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91
Date: Fri, 23 Aug 2019 21:50:30 +0200 [thread overview]
Message-ID: <20190823195030.GD30479@piout.net> (raw)
In-Reply-To: <20190823024346.591-1-yamada.masahiro@socionext.com>
On 23/08/2019 11:43:45+0900, Masahiro Yamada wrote:
> <generated/at91_pm_data-offsets.h> is only generated and included by
> arch/arm/mach-at91/, so it does not need to reside in the globally
> visible include/generated/.
>
> I renamed it to arch/arm/mach-at91/pm_data-offsets.h since the prefix
> 'at91_' is just redundant in mach-at91/.
>
> My main motivation of this change is to avoid the race condition for
> the parallel build (-j) when CONFIG_IKHEADERS is enabled.
>
> When it is enabled, all the headers under include/ are archived into
> kernel/kheaders_data.tar.xz and exposed in the sysfs.
>
> In the parallel build, we have no idea in which order files are built.
>
> - If at91_pm_data-offsets.h is built before kheaders_data.tar.xz,
> the header will be included in the archive. Probably nobody will
> use it, but it is harmless except that it will increase the archive
> size needlessly.
>
> - If kheaders_data.tar.xz is built before at91_pm_data-offsets.h,
> the header will not be included in the archive. However, in the next
> build, the archive will be re-generated to include the newly-found
> at91_pm_data-offsets.h. This is not nice from the build system point
> of view.
>
> - If at91_pm_data-offsets.h and kheaders_data.tar.xz are built at the
> same time, the corrupted header might be included in the archive,
> which does not look nice either.
>
> This commit fixes the race.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext•com>
> ---
>
> arch/arm/mach-at91/.gitignore | 1 +
> arch/arm/mach-at91/Makefile | 5 +++--
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/mach-at91/.gitignore
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-23 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 2:43 [PATCH] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91 Masahiro Yamada
2019-08-23 19:50 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823195030.GD30479@piout.net \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=ludovic.desroches@microchip$(echo .)com \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox