Subject: Re: [PATCH] ARM: dts: imx7: fix USB controller 'size' parameter

From: Peter Chen <[email-masked]>
Date: Fri, 30 Aug 2019 02:25:40 +0000

On 19-08-29 17:49:13, Thomas Schaefer wrote:
> Currently the size parameter in the reg property of usbotg and
> usbh nodes in imx7s and imx7d dts includes is set to 0x200 which
> is wrong for the i.MX7 CPU. According to reference manual, spacing
> of USB controller registers is 0x10000 instead.
> 
> This patch will fix this and set the 'size' to 0x10000.
> 
> Signed-off-by: Thomas Schaefer <[email-masked]>
> ---
>  arch/arm/boot/dts/imx7d.dtsi | 2 +-
>  arch/arm/boot/dts/imx7s.dtsi | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 42528d2812a2..f1b098d28b6e 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -117,7 +117,7 @@
>  &aips3 {
>  	usbotg2: usb@30b20000 {
>  		compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> -		reg = <0x30b20000 0x200>;
> +		reg = <0x30b20000 0x10000>;
>  		interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
>  		clocks = <&clks IMX7D_USB_CTRL_CLK>;
>  		fsl,usbphy = <&usbphynop2>;
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index c1a4fff5ceda..9e25fccf33f0 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -1088,7 +1088,7 @@
>  
>  			usbotg1: usb@30b10000 {
>  				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> -				reg = <0x30b10000 0x200>;
> +				reg = <0x30b10000 0x10000>;
>  				interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX7D_USB_CTRL_CLK>;
>  				fsl,usbphy = <&usbphynop1>;
> @@ -1099,7 +1099,7 @@
>  
>  			usbh: usb@30b30000 {
>  				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> -				reg = <0x30b30000 0x200>;
> +				reg = <0x30b30000 0x10000>;
>  				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX7D_USB_CTRL_CLK>;
>  				fsl,usbphy = <&usbphynop3>;

Hi Thomos,

The core controller range is 0x200, from offset 0x200, it is
non-core register, which is used by usbmisc. Fabio said you
met problem at u-boot for this size, what's the problem about
it?

Thanks,
Peter
_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel