public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel•org>
To: Anson Huang <Anson.Huang@nxp•com>
Cc: mark.rutland@arm•com, ulf.hansson@linaro•org, ping.bai@nxp•com,
	catalin.marinas@arm•com, peng.fan@nxp•com, stefan@agner•ch,
	bjorn.andersson@linaro•org, leonard.crestez@nxp•com,
	will@kernel•org, dinguyen@kernel•org, festevam@gmail•com,
	marcin.juszkiewicz@linaro•org, jagan@amarulasolutions•com,
	linux-input@vger•kernel.org, ronald@innovation•ch,
	Linux-imx@nxp•com, devicetree@vger•kernel.org, arnd@arndb•de,
	s.hauer@pengutronix•de, mripard@kernel•org,
	m.felsch@pengutronix•de, tglx@linutronix•de,
	andriy.shevchenko@linux•intel.com, daniel.baluta@nxp•com,
	linux-arm-kernel@lists•infradead.org, aisheng.dong@nxp•com,
	fugang.duan@nxp•com, gregkh@linuxfoundation•org,
	dmitry.torokhov@gmail•com, linux-kernel@vger•kernel.org,
	hsweeten@visionengravers•com, kernel@pengutronix•de,
	olof@lixom•net, shawnguo@kernel•org
Subject: Re: [PATCH 1/5] dt-bindings: fsl: scu: add scu power key binding
Date: Mon, 02 Sep 2019 14:39:14 +0100	[thread overview]
Message-ID: <20190902043521.GA14143@bogus> (raw)
In-Reply-To: <1567198429-27886-1-git-send-email-Anson.Huang@nxp.com>

On Fri, Aug 30, 2019 at 04:53:45PM -0400, Anson Huang wrote:
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
> system controller, the system controller is in charge of system
> power, clock and power key event etc. management, Linux kernel
> has to communicate with system controller via MU (message unit)
> IPC to get power key event, add binding doc for i.MX system
> controller power key driver.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
> ---
>  .../devicetree/bindings/arm/freescale/fsl,scu.txt      | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index c149fad..001d0b7 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -157,6 +157,17 @@ Required properties:
>  Optional properties:
>  - timeout-sec: contains the watchdog timeout in seconds.
>  
> +Power key bindings based on SCU Message Protocol
> +------------------------------------------------------------
> +
> +Required properties:
> +- compatible: should be:
> +              "fsl,imx8qxp-sc-pwrkey"
> +              followed by "fsl,imx-sc-pwrkey";
> +- linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
> +Optional Properties:
> +- wakeup-source: See Documentation/devicetree/bindings/power/wakeup-source.txt
> +
>  Example (imx8qxp):
>  -------------
>  aliases {
> @@ -220,6 +231,13 @@ firmware {
>  			compatible = "fsl,imx8qxp-sc-rtc";
>  		};
>  
> +		scu_pwrkey: scu-pwrkey {
> +			compatible = "fsl,imx8qxp-sc-pwrkey", "fsl,imx-sc-pwrkey";
> +			linux,keycode = <KEY_POWER>;
> +			wakeup-source;

wakeup-source implies an interrupt property.

> +			status = "disabled";

Don't should status in examples.

> +		};
> +
>  		watchdog {
>  			compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt";
>  			timeout-sec = <60>;
> -- 
> 2.7.4
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-09-02 13:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 20:53 [PATCH 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang
2019-08-30 20:53 ` [PATCH 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support Anson Huang
2019-08-30 20:53 ` [PATCH 3/5] arm64: dts: imx8qxp: Add scu power key node Anson Huang
2019-08-30 20:53 ` [PATCH 4/5] arm64: dts: imx8qxp-mek: Enable scu power key Anson Huang
2019-08-30 20:53 ` [PATCH 5/5] arm64: defconfig: Enable CONFIG_KEYBOARD_IMX_SC_PWRKEY as module Anson Huang
2019-09-02 13:39 ` Rob Herring [this message]
2019-09-03  2:05   ` [PATCH 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902043521.GA14143@bogus \
    --to=robh@kernel$(echo .)org \
    --cc=Anson.Huang@nxp$(echo .)com \
    --cc=Linux-imx@nxp$(echo .)com \
    --cc=aisheng.dong@nxp$(echo .)com \
    --cc=andriy.shevchenko@linux$(echo .)intel.com \
    --cc=arnd@arndb$(echo .)de \
    --cc=bjorn.andersson@linaro$(echo .)org \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=daniel.baluta@nxp$(echo .)com \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=dinguyen@kernel$(echo .)org \
    --cc=dmitry.torokhov@gmail$(echo .)com \
    --cc=festevam@gmail$(echo .)com \
    --cc=fugang.duan@nxp$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=hsweeten@visionengravers$(echo .)com \
    --cc=jagan@amarulasolutions$(echo .)com \
    --cc=kernel@pengutronix$(echo .)de \
    --cc=leonard.crestez@nxp$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-input@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=m.felsch@pengutronix$(echo .)de \
    --cc=marcin.juszkiewicz@linaro$(echo .)org \
    --cc=mark.rutland@arm$(echo .)com \
    --cc=mripard@kernel$(echo .)org \
    --cc=olof@lixom$(echo .)net \
    --cc=peng.fan@nxp$(echo .)com \
    --cc=ping.bai@nxp$(echo .)com \
    --cc=ronald@innovation$(echo .)ch \
    --cc=s.hauer@pengutronix$(echo .)de \
    --cc=shawnguo@kernel$(echo .)org \
    --cc=stefan@agner$(echo .)ch \
    --cc=tglx@linutronix$(echo .)de \
    --cc=ulf.hansson@linaro$(echo .)org \
    --cc=will@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox