From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Yizhuo Zhai <yzhai003@ucr•edu>
Cc: Chengyu Song <csong@cs•ucr.edu>,
Daniel Lezcano <daniel.lezcano@linaro•org>,
Zhiyun Qian <zhiyunq@cs•ucr.edu>,
linux-kernel@vger•kernel.org,
Ludovic Desroches <ludovic.desroches@microchip•com>,
Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] clocksource: atmel-st: Variable sr in at91rm9200_timer_interrupt() could be uninitialized
Date: Tue, 3 Sep 2019 10:16:58 +0200 [thread overview]
Message-ID: <20190903081658.GK21922@piout.net> (raw)
In-Reply-To: <CABvMjLRjeXAmhBwfZZPbmxdENq=FP9rR0Ld=T3veGXF6cjptxA@mail.gmail.com>
On 02/09/2019 22:56:48-0700, Yizhuo Zhai wrote:
> In function regmap_read(), there're two places which could make the read fail.
>
> First, if "reg" and "map->reg_stride" are not aligned, then remap_read() will
> return -EINVAL without initialize variable "val".
>
A quick look at of_syscon_register would show you that this is not
possible.
> Second, _regmap_read() could also fail and return error code if "val" is not
> initialized. The caller remap_read() returns the same error code, but
> at91rm9200_timer_interrupt() does not use this information.
>
How would _regmap_read fail exactly?
> On Mon, Sep 2, 2019 at 3:37 PM Alexandre Belloni
> <alexandre.belloni@bootlin•com> wrote:
> >
> > On 02/09/2019 15:29:46-0700, Yizhuo wrote:
> > > Inside function at91rm9200_timer_interrupt(), variable sr could
> > > be uninitialized if regmap_read() fails. However, sr is used
> >
> > Could you elaborate on how this could fail?
> >
> > > to decide the control flow later in the if statement, which is
> > > potentially unsafe. We could check the return value of
> > > regmap_read() and print an error here.
> > >
> > > Signed-off-by: Yizhuo <yzhai003@ucr•edu>
> > > ---
> > > drivers/clocksource/timer-atmel-st.c | 8 +++++++-
> > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/clocksource/timer-atmel-st.c b/drivers/clocksource/timer-atmel-st.c
> > > index ab0aabfae5f0..061a3f27847e 100644
> > > --- a/drivers/clocksource/timer-atmel-st.c
> > > +++ b/drivers/clocksource/timer-atmel-st.c
> > > @@ -48,8 +48,14 @@ static inline unsigned long read_CRTR(void)
> > > static irqreturn_t at91rm9200_timer_interrupt(int irq, void *dev_id)
> > > {
> > > u32 sr;
> > > + int ret;
> > > +
> > > + ret = regmap_read(regmap_st, AT91_ST_SR, &sr);
> > > + if (ret) {
> > > + pr_err("Fail to read AT91_ST_SR.\n");
> > > + return ret;
> > > + }
> > >
> > > - regmap_read(regmap_st, AT91_ST_SR, &sr);
> > > sr &= irqmask;
> > >
> > > /*
> > > --
> > > 2.17.1
> > >
> >
> > --
> > Alexandre Belloni, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
>
>
>
> --
> Kind Regards,
>
> Yizhuo Zhai
>
> Computer Science, Graduate Student
> University of California, Riverside
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-03 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 22:29 [PATCH] clocksource: atmel-st: Variable sr in at91rm9200_timer_interrupt() could be uninitialized Yizhuo
2019-09-02 22:36 ` Alexandre Belloni
2019-09-03 5:56 ` Yizhuo Zhai
2019-09-03 8:16 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903081658.GK21922@piout.net \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=csong@cs$(echo .)ucr.edu \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=ludovic.desroches@microchip$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=yzhai003@ucr$(echo .)edu \
--cc=zhiyunq@cs$(echo .)ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox