From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: YueHaibing <yuehaibing@huawei•com>
Cc: tmaimon77@gmail•com, palmer@sifive•com, tali.perry1@gmail•com,
eric@anholt•net, ldewangan@nvidia•com,
linux-riscv@lists•infradead.org, festevam@gmail•com,
linux-samsung-soc@vger•kernel.org, f.fainelli@gmail•com,
benjaminfair@google•com, shc_work@mail•ru, khilman@baylibre•com,
openbmc@lists•ozlabs.org, michal.simek@xilinx•com,
krzk@kernel•org, jonathanh@nvidia•com, yuenn@google•com,
wens@csie•org, agross@kernel•org,
bcm-kernel-feedback-list@broadcom•com, linux-imx@nxp•com,
linux-arm-msm@vger•kernel.org, linux-tegra@vger•kernel.org,
andi@etezian•org, rjui@broadcom•com, s.hauer@pengutronix•de,
mripard@kernel•org, broonie@kernel•org,
linux-mediatek@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org, paul.walmsley@sifive•com,
matthias.bgg@gmail•com, linux-amlogic@lists•infradead.org,
linux-arm-kernel@lists•infradead.org, baohua@kernel•org,
sbranden@broadcom•com, yamada.masahiro@socionext•com,
avifishman70@gmail•com, venture@google•com,
linux-kernel@vger•kernel.org, linux-spi@vger•kernel.org,
thierry.reding@gmail•com, wahrenst@gmx•net,
kernel@pengutronix•de, kgene@kernel•org, shawnguo@kernel•org
Subject: Re: [PATCH -next 23/36] spi: spi-qcom-qspi: use devm_platform_ioremap_resource() to simplify code
Date: Wed, 4 Sep 2019 13:46:49 -0700 [thread overview]
Message-ID: <20190904204649.GF580@tuxbook-pro> (raw)
In-Reply-To: <20190904135918.25352-24-yuehaibing@huawei.com>
On Wed 04 Sep 06:59 PDT 2019, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro•org>
> Reported-by: Hulk Robot <hulkci@huawei•com>
> Signed-off-by: YueHaibing <yuehaibing@huawei•com>
> ---
> drivers/spi/spi-qcom-qspi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c
> index a0ad73f..250fd60 100644
> --- a/drivers/spi/spi-qcom-qspi.c
> +++ b/drivers/spi/spi-qcom-qspi.c
> @@ -424,7 +424,6 @@ static int qcom_qspi_probe(struct platform_device *pdev)
> {
> int ret;
> struct device *dev;
> - struct resource *res;
> struct spi_master *master;
> struct qcom_qspi *ctrl;
>
> @@ -440,8 +439,7 @@ static int qcom_qspi_probe(struct platform_device *pdev)
>
> spin_lock_init(&ctrl->lock);
> ctrl->dev = dev;
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ctrl->base = devm_ioremap_resource(dev, res);
> + ctrl->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ctrl->base)) {
> ret = PTR_ERR(ctrl->base);
> goto exit_probe_master_put;
> --
> 2.7.4
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-04 20:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 13:58 [PATCH -next 00/36] use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-09-04 13:58 ` [PATCH -next 01/36] spi: altera: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 02/36] spi: a3700: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 03/36] spi: ath79: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 04/36] spi: spi-axi: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 05/36] spi: bcm2835aux: " YueHaibing
2019-09-05 18:38 ` Stefan Wahren
2019-09-04 13:58 ` [PATCH -next 06/36] spi: bcm2835: " YueHaibing
2019-09-05 18:39 ` Stefan Wahren
2019-09-04 13:58 ` [PATCH -next 07/36] spi: bcm63xx-hsspi: " YueHaibing
2019-09-04 22:10 ` Florian Fainelli
2019-09-04 13:58 ` [PATCH -next 08/36] spi: cadence: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 09/36] spi: octeon: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 10/36] spi: clps711x: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 11/36] spi: coldfire-qspi: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 12/36] spi: dw-mmio: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 13/36] spi: spi-geni-qcom: " YueHaibing
2019-09-04 20:44 ` Bjorn Andersson
2019-09-04 13:58 ` [PATCH -next 14/36] spi: lp-8841: " YueHaibing
2019-09-04 13:58 ` [PATCH -next 15/36] spi: meson-spicc: " YueHaibing
2019-09-04 14:13 ` Neil Armstrong
2019-09-04 13:58 ` [PATCH -next 16/36] spi: spi-meson-spifc: " YueHaibing
2019-09-04 14:14 ` Neil Armstrong
2019-09-04 13:58 ` [PATCH -next 17/36] spi: mt7621: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 18/36] spi: mxs: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 19/36] spi: npcm: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 20/36] spi: nuc900: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 21/36] spi: oc-tiny: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 22/36] spi: pic32-sqi: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 23/36] spi: spi-qcom-qspi: " YueHaibing
2019-09-04 20:46 ` Bjorn Andersson [this message]
2019-09-04 13:59 ` [PATCH -next 24/36] spi: rb4xx: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 25/36] spi: s3c24xx: " YueHaibing
2019-09-04 14:28 ` Krzysztof Kozlowski
2019-09-04 14:39 ` Mark Brown
2019-09-04 15:09 ` Krzysztof Kozlowski
2019-09-04 16:13 ` Mark Brown
2019-09-04 14:42 ` Yuehaibing
2019-09-07 23:38 ` Andi Shyti
2019-09-05 10:08 ` Sylwester Nawrocki
2019-09-04 13:59 ` [PATCH -next 26/36] spi: sifive: " YueHaibing
2019-09-04 22:20 ` Paul Walmsley
2019-09-04 13:59 ` [PATCH -next 27/36] spi: sirf: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 28/36] spi: st-ssc4: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 29/36] spi: sun4i: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 30/36] spi: sun6i: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 31/36] spi: tegra: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 32/36] spi: uniphier: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 33/36] spi: xlp: " YueHaibing
2019-09-04 13:59 ` [PATCH -next 34/36] spi: zynqmp: " YueHaibing
2019-09-05 5:19 ` Michal Simek
2019-09-04 13:59 ` [PATCH -next 35/36] spi: zynq-qspi: " YueHaibing
2019-09-05 5:19 ` Michal Simek
2019-09-04 13:59 ` [PATCH -next 36/36] spi: fsl-spi: " YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904204649.GF580@tuxbook-pro \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=andi@etezian$(echo .)org \
--cc=avifishman70@gmail$(echo .)com \
--cc=baohua@kernel$(echo .)org \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=benjaminfair@google$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=eric@anholt$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kgene@kernel$(echo .)org \
--cc=khilman@baylibre$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=ldewangan@nvidia$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=michal.simek@xilinx$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=openbmc@lists$(echo .)ozlabs.org \
--cc=palmer@sifive$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=rjui@broadcom$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sbranden@broadcom$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=shc_work@mail$(echo .)ru \
--cc=tali.perry1@gmail$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tmaimon77@gmail$(echo .)com \
--cc=venture@google$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
--cc=wens@csie$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
--cc=yuenn@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox