From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: YueHaibing <yuehaibing@huawei•com>
Cc: mans@mansr•com, mmayer@broadcom•com, eric@anholt•net,
miquel.raynal@bootlin•com,
linux-stm32@st-md-mailman•stormreply.com, heiko@sntech•de,
amit.kucheria@verdurent•com, f.fainelli@gmail•com,
daniel.lezcano@linaro•org, phil@raspberrypi•org,
linux-rockchip@lists•infradead.org, agross@kernel•org,
bcm-kernel-feedback-list@broadcom•com,
linux-arm-msm@vger•kernel.org, rui.zhang@intel•com,
david.hernandezsanchez@st•com, alexandre.torgue@st•com,
marc.w.gonzalez@free•fr, rjui@broadcom•com, edubezval@gmail•com,
linux-mediatek@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org, gregory.0xf0@gmail•com,
matthias.bgg@gmail•com, horms+renesas@verge•net.au,
talel@amazon•com, linux-arm-kernel@lists•infradead.org,
sbranden@broadcom•com, wsa+renesas@sang-engineering•com,
gregkh@linuxfoundation•org, linux-pm@vger•kernel.org,
linux-kernel@vger•kernel.org, wahrenst@gmx•net,
mcoquelin.stm32@gmail•com, jun.nie@linaro•org,
computersforpeace@gmail•com, shawnguo@kernel•org
Subject: Re: [PATCH -next 08/15] thermal: tsens: use devm_platform_ioremap_resource() to simplify code
Date: Wed, 4 Sep 2019 14:50:39 -0700 [thread overview]
Message-ID: <20190904215039.GG580@tuxbook-pro> (raw)
In-Reply-To: <20190904122939.23780-9-yuehaibing@huawei.com>
On Wed 04 Sep 05:29 PDT 2019, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro•org>
> Reported-by: Hulk Robot <hulkci@huawei•com>
> Signed-off-by: YueHaibing <yuehaibing@huawei•com>
> ---
> drivers/thermal/qcom/tsens-common.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index 528df88..43ce4fb 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -155,7 +155,6 @@ int __init init_common(struct tsens_priv *priv)
> {
> void __iomem *tm_base, *srot_base;
> struct device *dev = priv->dev;
> - struct resource *res;
> u32 enabled;
> int ret, i, j;
> struct platform_device *op = of_find_device_by_node(priv->dev->of_node);
> @@ -166,8 +165,7 @@ int __init init_common(struct tsens_priv *priv)
> if (op->num_resources > 1) {
> /* DT with separate SROT and TM address space */
> priv->tm_offset = 0;
> - res = platform_get_resource(op, IORESOURCE_MEM, 1);
> - srot_base = devm_ioremap_resource(&op->dev, res);
> + srot_base = devm_platform_ioremap_resource(op, 1);
> if (IS_ERR(srot_base)) {
> ret = PTR_ERR(srot_base);
> goto err_put_device;
> @@ -184,8 +182,7 @@ int __init init_common(struct tsens_priv *priv)
> priv->tm_offset = 0x1000;
> }
>
> - res = platform_get_resource(op, IORESOURCE_MEM, 0);
> - tm_base = devm_ioremap_resource(&op->dev, res);
> + tm_base = devm_platform_ioremap_resource(op, 0);
> if (IS_ERR(tm_base)) {
> ret = PTR_ERR(tm_base);
> goto err_put_device;
> --
> 2.7.4
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-04 21:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 12:29 [PATCH -next 00/15] use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-09-04 12:29 ` [PATCH -next 01/15] thermal: armada: " YueHaibing
2019-09-04 12:43 ` Miquel Raynal
2019-09-04 12:29 ` [PATCH -next 02/15] thermal: bcm2835: " YueHaibing
2019-09-05 18:41 ` Stefan Wahren
2019-09-04 12:29 ` [PATCH -next 03/15] thermal: brcmstb: " YueHaibing
2019-09-04 17:00 ` Florian Fainelli
2019-09-04 12:29 ` [PATCH -next 04/15] thermal: hisilicon: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 05/15] thermal: dove: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 06/15] thermal: mtk: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 07/15] thermal: kirkwood: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 08/15] thermal: tsens: " YueHaibing
2019-09-04 21:50 ` Bjorn Andersson [this message]
2019-09-05 6:15 ` Amit Kucheria
2019-09-04 12:29 ` [PATCH -next 09/15] thermal: rockchip: " YueHaibing
2019-10-04 21:49 ` Heiko Stuebner
2019-09-04 12:29 ` [PATCH -next 10/15] thermal: spear: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 11/15] thermal: stm32: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 12/15] thermal: tango: " YueHaibing
2019-09-05 11:06 ` Måns Rullgård
2019-09-04 12:29 ` [PATCH -next 13/15] thermal: thermal_mmio: " YueHaibing
2019-09-04 13:15 ` Talel Shenhar
2019-09-04 12:29 ` [PATCH -next 14/15] thermal: zx2967: " YueHaibing
2019-09-04 12:29 ` [PATCH -next 15/15] thermal: rcar: " YueHaibing
2019-09-04 17:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904215039.GG580@tuxbook-pro \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=alexandre.torgue@st$(echo .)com \
--cc=amit.kucheria@verdurent$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=computersforpeace@gmail$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=david.hernandezsanchez@st$(echo .)com \
--cc=edubezval@gmail$(echo .)com \
--cc=eric@anholt$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gregory.0xf0@gmail$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=horms+renesas@verge$(echo .)net.au \
--cc=jun.nie@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mans@mansr$(echo .)com \
--cc=marc.w.gonzalez@free$(echo .)fr \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mmayer@broadcom$(echo .)com \
--cc=phil@raspberrypi$(echo .)org \
--cc=rjui@broadcom$(echo .)com \
--cc=rui.zhang@intel$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=talel@amazon$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
--cc=wsa+renesas@sang-engineering$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox