From: Sakari Ailus <sakari.ailus@linux•intel.com>
To: Dongchun Zhu <dongchun.zhu@mediatek•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
drinkcat@chromium•org, srv_heupstream@mediatek•com,
shengnan.wang@mediatek•com, tfiga@chromium•org,
louis.kuo@mediatek•com, sj.huang@mediatek•com,
robh+dt@kernel•org, linux-mediatek@lists•infradead.org,
matthias.bgg@gmail•com, bingbu.cao@intel•com, mchehab@kernel•org,
linux-arm-kernel@lists•infradead.org,
linux-media@vger•kernel.org
Subject: Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver
Date: Thu, 5 Sep 2019 13:45:46 +0300 [thread overview]
Message-ID: <20190905104546.GA5475@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1567676465.21623.100.camel@mhfsdcap03>
Hi Dongchun,
On Thu, Sep 05, 2019 at 05:41:05PM +0800, Dongchun Zhu wrote:
...
> > > + ret = regulator_bulk_enable(OV02A10_NUM_SUPPLIES, ov02a10->supplies);
> > > + if (ret < 0) {
> > > + dev_err(dev, "Failed to enable regulators\n");
> > > + goto disable_clk;
> > > + }
> > > + msleep_range(7);
> >
> > This has some potential of clashing with more generic functions in the
> > future. Please use usleep_range directly, or msleep.
> >
>
> Did you mean using usleep_range(7*1000, 8*1000), as used in patch v1?
> https://patchwork.kernel.org/patch/10957225/
Yes, please.
--
Sakari Ailus
sakari.ailus@linux•intel.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-05 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 3:43 [V3, 0/2] media: Add support for OV02A10 sensor dongchun.zhu
2019-08-19 3:43 ` [V3, 1/2] media: dt-bindings: media: i2c: Add bindings for OV02A10 dongchun.zhu
2019-08-27 16:48 ` Rob Herring
2019-08-19 3:43 ` [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver dongchun.zhu
2019-08-19 8:30 ` Sakari Ailus
2019-09-05 9:41 ` Dongchun Zhu
2019-09-05 10:45 ` Sakari Ailus [this message]
2019-09-05 10:53 ` Tomasz Figa
2019-09-05 16:05 ` Sakari Ailus
2019-09-05 22:58 ` Nicolas Boichat
2019-09-06 1:33 ` Dongchun Zhu
2019-09-07 3:51 ` Tomasz Figa
2019-08-21 10:30 ` Tomasz Figa
2019-08-21 11:05 ` Sakari Ailus
2019-08-26 6:54 ` Tomasz Figa
2019-09-05 15:54 ` Dongchun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905104546.GA5475@paasikivi.fi.intel.com \
--to=sakari.ailus@linux$(echo .)intel.com \
--cc=bingbu.cao@intel$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dongchun.zhu@mediatek$(echo .)com \
--cc=drinkcat@chromium$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=louis.kuo@mediatek$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=shengnan.wang@mediatek$(echo .)com \
--cc=sj.huang@mediatek$(echo .)com \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=tfiga@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox