From: Sakari Ailus <sakari.ailus@linux•intel.com>
To: Javier Martinez Canillas <javier@dowhile0•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, drinkcat@chromium•org,
srv_heupstream@mediatek•com, sam.hung@mediatek•com,
shengnan.wang@mediatek•com,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Tomasz Figa <tfiga@chromium•org>,
sj.huang@mediatek•com, Rob Herring <robh+dt@kernel•org>,
linux-mediatek@lists•infradead.org, dongchun.zhu@mediatek•com,
Matthias Brugger <matthias.bgg@gmail•com>,
bingbu.cao@intel•com, Mauro Carvalho Chehab <mchehab@kernel•org>,
linux-arm-kernel@lists•infradead.org,
Linux Media Mailing List <linux-media@vger•kernel.org>
Subject: Re: [V2, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry
Date: Thu, 5 Sep 2019 15:00:12 +0300 [thread overview]
Message-ID: <20190905120012.GD5475@paasikivi.fi.intel.com> (raw)
In-Reply-To: <CABxcv=knP+-x0O-Ga-Dy8WTNovHk6GfX4ZEv0vVjnQvwchuVzg@mail.gmail.com>
On Thu, Sep 05, 2019 at 01:49:28PM +0200, Javier Martinez Canillas wrote:
> On Thu, Sep 5, 2019 at 1:35 PM Andy Shevchenko
> <andriy.shevchenko@linux•intel.com> wrote:
> >
> > On Thu, Sep 05, 2019 at 01:48:30PM +0300, Sakari Ailus wrote:
> > > On Thu, Sep 05, 2019 at 01:14:06PM +0300, Andy Shevchenko wrote:
> > > > On Thu, Sep 05, 2019 at 03:21:41PM +0800, dongchun.zhu@mediatek•com wrote:
> > > > > From: Dongchun Zhu <dongchun.zhu@mediatek•com>
> > > > >
> > > > > This patch is to add the Devicetree binding documentation and
> > > > > MAINTAINERS entry for dw9768 actuator.
> > > > >
> > > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek•com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 +++++++++
> > > > > MAINTAINERS | 7 +++++++
> > > >
> > > > This should be:
> > > > 1) two separate patches
> > >
> > > Why? The MAINTAINERS entry is usually added in the first patch needing it,
> > > isn't it?
> >
> > Bindings are required to be a separate patch.
> > Rob, is it still the case or am I mistaken?
> >
>
> According to the rule 0 in [1] it should be a separate patch indeed
> and also use as subject "dt-bindings: <binding dir>: ..." which this
> patch also doesn't follow.
> So if I'm reading that document correctly, then I think the
> maintainers entry should be added in patch 2/2 along with the driver.
I understand [1] discussing the need for the bindings to be a "separate
patch" means a separate patch from the _driver_ for the device, not the
MAINTAINERS change.
Bindings come before the driver, and MAINTAINERS entry needs to be there no
later than the files. And I see no reason to add a separate patch just for
MAINTAINERS change.
>
> [1]: https://www.kernel.org/doc/Documentation/devicetree/bindings/submitting-patches.txt
--
Sakari Ailus
sakari.ailus@linux•intel.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-05 12:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 7:21 [V2, 0/2] media: i2c: add support for DW9768 VCM driver dongchun.zhu
2019-09-05 7:21 ` [V2, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry dongchun.zhu
2019-09-05 10:14 ` Andy Shevchenko
2019-09-05 10:48 ` Sakari Ailus
2019-09-05 11:35 ` Andy Shevchenko
2019-09-05 11:49 ` Javier Martinez Canillas
2019-09-05 12:00 ` Sakari Ailus [this message]
2019-09-05 12:24 ` Andy Shevchenko
2019-09-17 20:47 ` Rob Herring
2019-09-05 7:21 ` [V2, 2/2] media: i2c: Add DW9768 VCM driver dongchun.zhu
2019-09-05 8:21 ` Sakari Ailus
2019-09-05 10:19 ` Andy Shevchenko
2019-09-05 10:40 ` Sakari Ailus
2019-09-05 10:57 ` Javier Martinez Canillas
2019-09-05 11:36 ` Andy Shevchenko
2019-09-05 8:28 ` Tomasz Figa
2019-09-05 10:26 ` Andy Shevchenko
[not found] ` <e8b59857e39744a6acfe5d862f3ac8d5@mtkmbs05n2.mediatek.inc>
2020-01-20 8:34 ` Dongchun Zhu
2019-09-07 22:12 ` kbuild test robot
2019-10-09 4:40 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905120012.GD5475@paasikivi.fi.intel.com \
--to=sakari.ailus@linux$(echo .)intel.com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bingbu.cao@intel$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dongchun.zhu@mediatek$(echo .)com \
--cc=drinkcat@chromium$(echo .)org \
--cc=javier@dowhile0$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=sam.hung@mediatek$(echo .)com \
--cc=shengnan.wang@mediatek$(echo .)com \
--cc=sj.huang@mediatek$(echo .)com \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=tfiga@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox