public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: Tom Murphy <murphyt7@tcd•ie>
To: iommu@lists•linux-foundation.org
Cc: Heiko Stuebner <heiko@sntech•de>,
	virtualization@lists•linux-foundation.org,
	linux-tegra@vger•kernel.org,
	Thierry Reding <thierry.reding@gmail•com>,
	Will Deacon <will@kernel•org>,
	Marek Szyprowski <m.szyprowski@samsung•com>,
	Jean-Philippe Brucker <jean-philippe@linaro•org>,
	linux-samsung-soc@vger•kernel.org, Joerg Roedel <joro@8bytes•org>,
	Krzysztof Kozlowski <krzk@kernel•org>,
	Jonathan Hunter <jonathanh@nvidia•com>,
	linux-rockchip@lists•infradead.org,
	Andy Gross <agross@kernel•org>,
	Gerald Schaefer <gerald.schaefer@de•ibm.com>,
	linux-s390@vger•kernel.org, linux-arm-msm@vger•kernel.org,
	linux-mediatek@lists•infradead.org,
	Matthias Brugger <matthias.bgg@gmail•com>,
	linux-arm-kernel@lists•infradead.org,
	David Woodhouse <dwmw2@infradead•org>,
	linux-kernel@vger•kernel.org, Tom Murphy <murphyt7@tcd•ie>,
	Rob Clark <robdclark@gmail•com>, Kukjin Kim <kgene@kernel•org>,
	Robin Murphy <robin.murphy@arm•com>
Subject: [PATCH V6 3/5] iommu/dma-iommu: Handle deferred devices
Date: Sun,  8 Sep 2019 09:56:39 -0700	[thread overview]
Message-ID: <20190908165642.22253-4-murphyt7@tcd.ie> (raw)
In-Reply-To: <20190908165642.22253-1-murphyt7@tcd.ie>

Handle devices which defer their attach to the iommu in the dma-iommu api

Signed-off-by: Tom Murphy <murphyt7@tcd•ie>
Reviewed-by: Robin Murphy <robin.murphy@arm•com>
---
 drivers/iommu/dma-iommu.c | 27 ++++++++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
index 2712fbc68b28..bd09b6b31c4e 100644
--- a/drivers/iommu/dma-iommu.c
+++ b/drivers/iommu/dma-iommu.c
@@ -22,6 +22,7 @@
 #include <linux/pci.h>
 #include <linux/scatterlist.h>
 #include <linux/vmalloc.h>
+#include <linux/crash_dump.h>
 
 struct iommu_dma_msi_page {
 	struct list_head	list;
@@ -351,6 +352,21 @@ static int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,
 	return iova_reserve_iommu_regions(dev, domain);
 }
 
+static int iommu_dma_deferred_attach(struct device *dev,
+		struct iommu_domain *domain)
+{
+	const struct iommu_ops *ops = domain->ops;
+
+	if (!is_kdump_kernel())
+		return 0;
+
+	if (unlikely(ops->is_attach_deferred &&
+			ops->is_attach_deferred(domain, dev)))
+		return iommu_attach_device(domain, dev);
+
+	return 0;
+}
+
 /**
  * dma_info_to_prot - Translate DMA API directions and attributes to IOMMU API
  *                    page flags.
@@ -463,6 +479,9 @@ static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys,
 	size_t iova_off = iova_offset(iovad, phys);
 	dma_addr_t iova;
 
+	if (unlikely(iommu_dma_deferred_attach(dev, domain)))
+		return DMA_MAPPING_ERROR;
+
 	size = iova_align(iovad, size + iova_off);
 
 	iova = iommu_dma_alloc_iova(domain, size, dma_get_mask(dev), dev);
@@ -581,6 +600,9 @@ static void *iommu_dma_alloc_remap(struct device *dev, size_t size,
 
 	*dma_handle = DMA_MAPPING_ERROR;
 
+	if (unlikely(iommu_dma_deferred_attach(dev, domain)))
+		return NULL;
+
 	min_size = alloc_sizes & -alloc_sizes;
 	if (min_size < PAGE_SIZE) {
 		min_size = PAGE_SIZE;
@@ -713,7 +735,7 @@ static dma_addr_t iommu_dma_map_page(struct device *dev, struct page *page,
 	int prot = dma_info_to_prot(dir, coherent, attrs);
 	dma_addr_t dma_handle;
 
-	dma_handle =__iommu_dma_map(dev, phys, size, prot);
+	dma_handle = __iommu_dma_map(dev, phys, size, prot);
 	if (!coherent && !(attrs & DMA_ATTR_SKIP_CPU_SYNC) &&
 	    dma_handle != DMA_MAPPING_ERROR)
 		arch_sync_dma_for_device(dev, phys, size, dir);
@@ -823,6 +845,9 @@ static int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg,
 	unsigned long mask = dma_get_seg_boundary(dev);
 	int i;
 
+	if (unlikely(iommu_dma_deferred_attach(dev, domain)))
+		return 0;
+
 	if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
 		iommu_dma_sync_sg_for_device(dev, sg, nents, dir);
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-09-08 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-08 16:56 [PATCH v6 0/5] iommu/amd: Convert the AMD iommu driver to the dma-iommu api Tom Murphy
2019-09-08 16:56 ` [PATCH V6 1/5] iommu/amd: Remove unnecessary locking from AMD iommu driver Tom Murphy
2019-09-08 16:56 ` [PATCH V6 2/5] iommu: Add gfp parameter to iommu_ops::map Tom Murphy
2019-09-08 16:56 ` Tom Murphy [this message]
2019-09-08 16:56 ` [PATCH V6 4/5] iommu/dma-iommu: Use the dev->coherent_dma_mask Tom Murphy
2020-07-10 15:59   ` Christoph Hellwig
2020-07-10 19:18     ` Tom Murphy
2019-09-08 16:56 ` [PATCH V6 5/5] iommu/amd: Convert AMD iommu driver to the dma-iommu api Tom Murphy
2019-10-08  9:08 ` [PATCH v6 0/5] iommu/amd: Convert the " Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190908165642.22253-4-murphyt7@tcd.ie \
    --to=murphyt7@tcd$(echo .)ie \
    --cc=agross@kernel$(echo .)org \
    --cc=dwmw2@infradead$(echo .)org \
    --cc=gerald.schaefer@de$(echo .)ibm.com \
    --cc=heiko@sntech$(echo .)de \
    --cc=iommu@lists$(echo .)linux-foundation.org \
    --cc=jean-philippe@linaro$(echo .)org \
    --cc=jonathanh@nvidia$(echo .)com \
    --cc=joro@8bytes$(echo .)org \
    --cc=kgene@kernel$(echo .)org \
    --cc=krzk@kernel$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-arm-msm@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-mediatek@lists$(echo .)infradead.org \
    --cc=linux-rockchip@lists$(echo .)infradead.org \
    --cc=linux-s390@vger$(echo .)kernel.org \
    --cc=linux-samsung-soc@vger$(echo .)kernel.org \
    --cc=linux-tegra@vger$(echo .)kernel.org \
    --cc=m.szyprowski@samsung$(echo .)com \
    --cc=matthias.bgg@gmail$(echo .)com \
    --cc=robdclark@gmail$(echo .)com \
    --cc=robin.murphy@arm$(echo .)com \
    --cc=thierry.reding@gmail$(echo .)com \
    --cc=virtualization@lists$(echo .)linux-foundation.org \
    --cc=will@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox