From: Marco Felsch <m.felsch@pengutronix•de>
To: Gilles Doffe <gilles.doffe@savoirfairelinux•com>
Cc: "mark rutland" <mark.rutland@arm•com>,
devicetree <devicetree@vger•kernel.org>,
shawnguo <shawnguo@kernel•org>,
"s hauer" <s.hauer@pengutronix•de>,
rennes <rennes@savoirfairelinux•com>,
linux-kernel <linux-kernel@vger•kernel.org>,
robh+dt <robh+dt@kernel•org>, linux-imx <linux-imx@nxp•com>,
kernel <kernel@pengutronix•de>,
"Jérome Oufella" <jerome.oufella@savoirfairelinux•com>,
festevam <festevam@gmail•com>,
linux-arm-kernel <linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2] arm: dts: imx6qdl: add gpio expander pca9535
Date: Thu, 12 Sep 2019 12:12:40 +0200 [thread overview]
Message-ID: <20190912101240.ml5jmdei5rvzesap@pengutronix.de> (raw)
In-Reply-To: <978100557.7721358.1568282514403.JavaMail.zimbra@savoirfairelinux.com>
Hi Gilles,
On 19-09-12 06:01, Gilles Doffe wrote:
> Hi Marco,
>
> Thanks for your reply and sorry about the delay.
No worries ;)
> ----- Le 22 Juil 19, à 9:53, Marco Felsch m.felsch@pengutronix•de a écrit :
>
> > Hi Gilles,
> >
> > can you adapt the patch title, I assumed that the base dtsi is adding a
> > gpio-expander which makes no sense.
>
> My first intent was to add the gpio-expander pca9535 into the imx6q-rex-pro.dts and in a future imx6qp-rex-ultra.dts
> However I noticed that the sgtl5000 was already in the dtsi.
> It is maybe due to the fact that like the pca9535, the sgtl5000 is present on the baseboard not on the SOM.
> Thus I guess that baseboard stuff common to all rex SOM should be in imx6qdl-rex.dtsi and not in the dts.
> Does-it seem correct to you ?
Yes this is correct what Shawn and I mean is that you should adapt the
commit title. Shawn already give you an example.
> >
> > On 19-07-19 12:46, Gilles DOFFE wrote:
> >> The pca9535 gpio expander is present on the Rex baseboard, but missing
> >> from the dtsi.
> >>
> >> Add the new gpio controller and the associated interrupt line
> >> MX6QDL_PAD_NANDF_CS3__GPIO6_IO16.
> >>
> >> Signed-off-by: Gilles DOFFE <gilles.doffe@savoirfairelinux•com>
> >> ---
> >
> > Having a changelog would be nice too.
> >
> >> arch/arm/boot/dts/imx6qdl-rex.dtsi | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx6qdl-rex.dtsi
> >> b/arch/arm/boot/dts/imx6qdl-rex.dtsi
> >> index 97f1659144ea..b517efb22fcb 100644
> >> --- a/arch/arm/boot/dts/imx6qdl-rex.dtsi
> >> +++ b/arch/arm/boot/dts/imx6qdl-rex.dtsi
> >> @@ -136,6 +136,19 @@
> >> compatible = "atmel,24c02";
> >> reg = <0x57>;
> >> };
> >> +
> >> + pca9535: gpio8@27 {
> >> + compatible = "nxp,pca9535";
> >> + reg = <0x27>;
> >
> > The i2c devices are orderd by their i2c-addresses starting from the
> > lowest.
> >
>
> Ack.
>
> >> + gpio-controller;
> >> + #gpio-cells = <2>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_pca9535>;
> >> + interrupt-parent = <&gpio6>;
> >> + interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> >> + interrupt-controller;
> >> + #interrupt-cells = <2>;
As you pointed out above this device isn't available on the
imx6dl-rex-basic? You should add: 'status = "disabled";' if this is the
case.
Regards,
Marco
> >> + };
> >> };
> >>
> >> &i2c3 {
> >> @@ -237,6 +250,12 @@
> >> >;
> >> };
> >>
> >> + pinctrl_pca9535: pca9535 {
> >> + fsl,pins = <
> >> + MX6QDL_PAD_NANDF_CS3__GPIO6_IO16 0x00017059
> >
> > The pinmux below don't use the leading zero's if you are the first I
> > would drop that.
> >
> > Regards,
> > Marco
> >
>
> Ack.
>
> Regards,
> Gilles
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-12 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 10:46 [PATCH v2] arm: dts: imx6qdl: add gpio expander pca9535 Gilles DOFFE
2019-07-22 7:53 ` Marco Felsch
2019-07-23 8:02 ` Shawn Guo
2019-09-12 10:01 ` Gilles Doffe
2019-09-12 10:12 ` Marco Felsch [this message]
2019-09-13 8:38 ` Gilles Doffe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912101240.ml5jmdei5rvzesap@pengutronix.de \
--to=m.felsch@pengutronix$(echo .)de \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=gilles.doffe@savoirfairelinux$(echo .)com \
--cc=jerome.oufella@savoirfairelinux$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=rennes@savoirfairelinux$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox