From: "Kirill A. Shutemov" <kirill@shutemov•name>
To: Anshuman Khandual <anshuman.khandual@arm•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
Peter Zijlstra <peterz@infradead•org>,
James Hogan <jhogan@kernel•org>,
Tetsuo Handa <penguin-kernel@i-love•sakura.ne.jp>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Michal Hocko <mhocko@kernel•org>,
linux-mm@kvack•org, Paul Mackerras <paulus@samba•org>,
sparclinux@vger•kernel.org, Thomas Gleixner <tglx@linutronix•de>,
linux-s390@vger•kernel.org, Michael Ellerman <mpe@ellerman•id.au>,
x86@kernel•org, Russell King - ARM Linux <linux@armlinux•org.uk>,
Matthew Wilcox <willy@infradead•org>,
Steven Price <Steven.Price@arm•com>,
Jason Gunthorpe <jgg@ziepe•ca>,
Gerald Schaefer <gerald.schaefer@de•ibm.com>,
linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
Kees Cook <keescook@chromium•org>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Mark Brown <broonie@kernel•org>,
Dan Williams <dan.j.williams@intel•com>,
Vlastimil Babka <vbabka@suse•cz>,
Christophe Leroy <christophe.leroy@c-s•fr>,
Sri Krishna chowdary <schowdary@nvidia•com>,
Ard Biesheuvel <ard.biesheuvel@linaro•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Dave Hansen <dave.hansen@intel•com>,
linux-mips@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
linux-kernel@vger•kernel.org, Paul Burton <paul.burton@mips•com>,
Mike Rapoport <rppt@linux•vnet.ibm.com>,
Vineet Gupta <vgupta@synopsys•com>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture page table helpers
Date: Fri, 13 Sep 2019 12:13:05 +0300 [thread overview]
Message-ID: <20190913091305.rkds4f3fqv3yjhjy@box> (raw)
In-Reply-To: <502c497a-9bf1-7d2e-95f2-cfebcd9cf1d9@arm.com>
On Fri, Sep 13, 2019 at 02:32:04PM +0530, Anshuman Khandual wrote:
>
> On 09/12/2019 10:44 PM, Christophe Leroy wrote:
> >
> >
> > Le 12/09/2019 à 08:02, Anshuman Khandual a écrit :
> >> This adds a test module which will validate architecture page table helpers
> >> and accessors regarding compliance with generic MM semantics expectations.
> >> This will help various architectures in validating changes to the existing
> >> page table helpers or addition of new ones.
> >>
> >> Test page table and memory pages creating it's entries at various level are
> >> all allocated from system memory with required alignments. If memory pages
> >> with required size and alignment could not be allocated, then all depending
> >> individual tests are skipped.
> >>
> >
> > [...]
> >
> >>
> >> Suggested-by: Catalin Marinas <catalin.marinas@arm•com>
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm•com>
> >> ---
> >> arch/x86/include/asm/pgtable_64_types.h | 2 +
> >> mm/Kconfig.debug | 14 +
> >> mm/Makefile | 1 +
> >> mm/arch_pgtable_test.c | 429 ++++++++++++++++++++++++
> >> 4 files changed, 446 insertions(+)
> >> create mode 100644 mm/arch_pgtable_test.c
> >>
> >> diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h
> >> index 52e5f5f2240d..b882792a3999 100644
> >> --- a/arch/x86/include/asm/pgtable_64_types.h
> >> +++ b/arch/x86/include/asm/pgtable_64_types.h
> >> @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void)
> >> #define pgtable_l5_enabled() 0
> >> #endif /* CONFIG_X86_5LEVEL */
> >> +#define mm_p4d_folded(mm) (!pgtable_l5_enabled())
> >> +
> >
> > This is specific to x86, should go in a separate patch.
>
> Thought about it but its just a single line. Kirill suggested this in the
> previous version. There is a generic fallback definition but s390 has it's
> own. This change overrides the generic one for x86 probably as a fix or as
> an improvement. Kirill should be able to help classify it in which case it
> can be a separate patch.
I don't think it worth a separate patch.
--
Kirill A. Shutemov
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-13 9:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 6:02 [PATCH V2 0/2] mm/debug: Add tests for architecture exported page table helpers Anshuman Khandual
2019-09-12 6:02 ` [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture " Anshuman Khandual
2019-09-12 11:00 ` Kirill A. Shutemov
2019-09-12 12:09 ` Anshuman Khandual
2019-09-12 15:00 ` Christophe Leroy
2019-09-12 15:36 ` Christophe Leroy
2019-09-12 15:52 ` Christophe Leroy
2019-09-13 6:30 ` Christophe Leroy
2019-09-12 17:14 ` Christophe Leroy
2019-09-13 6:23 ` [PATCH] mm/pgtable/debug: Fix " Christophe Leroy
2019-09-13 6:58 ` Anshuman Khandual
2019-09-13 7:03 ` Christophe Leroy
2019-09-13 7:11 ` Christophe Leroy
2019-09-13 8:42 ` Anshuman Khandual
2019-09-13 8:51 ` Kirill A. Shutemov
2019-09-18 7:32 ` Anshuman Khandual
2019-09-19 5:44 ` Christophe Leroy
2019-09-13 9:02 ` [PATCH V2 2/2] mm/pgtable/debug: Add " Anshuman Khandual
2019-09-13 9:13 ` Kirill A. Shutemov [this message]
2019-09-13 10:01 ` Christophe Leroy
2019-09-18 5:04 ` Anshuman Khandual
2019-09-18 16:26 ` Christophe Leroy
2019-09-18 18:22 ` Gerald Schaefer
2019-09-20 4:06 ` Anshuman Khandual
2019-09-19 4:56 ` Anshuman Khandual
2019-09-19 5:41 ` Christophe Leroy
2019-09-12 14:42 ` [PATCH V2 0/2] mm/debug: Add tests for architecture exported " Christophe Leroy
2019-09-13 6:24 ` Anshuman Khandual
2019-09-13 6:32 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913091305.rkds4f3fqv3yjhjy@box \
--to=kirill@shutemov$(echo .)name \
--cc=Steven.Price@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gerald.schaefer@de$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jhogan@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mhocko@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=penguin-kernel@i-love$(echo .)sakura.ne.jp \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=schowdary@nvidia$(echo .)com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@synopsys$(echo .)com \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox