From: Lukasz Luba <l.luba@partner•samsung.com>
To: devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-pm@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Cc: mark.rutland@arm•com, willy.mh.wolff.ml@gmail•com,
b.zolnierkie@samsung•com, krzk@kernel•org,
Lukasz Luba <l.luba@partner•samsung.com>,
cw00.choi@samsung•com, kyungmin.park@samsung•com,
robh+dt@kernel•org, kgene@kernel•org, s.nawrocki@samsung•com,
myungjoo.ham@samsung•com, m.szyprowski@samsung•com
Subject: [PATCH v2 1/3] memory: Exynos5422: minor fixes in DMC
Date: Mon, 16 Sep 2019 12:07:02 +0200 [thread overview]
Message-ID: <20190916100704.26692-2-l.luba@partner.samsung.com> (raw)
In-Reply-To: <20190916100704.26692-1-l.luba@partner.samsung.com>
Small fixes for issues captured by static analyzes:
used kfree() insead of devm_kfree() and missing 'static' in the private
function.
Checks which show the issues:
- drivers/memory/samsung/exynos5422-dmc.c:272 exynos5_init_freq_table()
warn: passing devm_ allocated variable to kfree. 'dmc->opp'
- drivers/memory/samsung/exynos5422-dmc.c:736:1: warning: symbol
'exynos5_dmc_align_init_freq' was not declared.
Reported-by: Krzysztof Kozlowski <krzk@kernel•org>
Signed-off-by: Lukasz Luba <l.luba@partner•samsung.com>
---
drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
index 8c2ec29a7d57..a809fa997c03 100644
--- a/drivers/memory/samsung/exynos5422-dmc.c
+++ b/drivers/memory/samsung/exynos5422-dmc.c
@@ -269,7 +269,7 @@ static int exynos5_init_freq_table(struct exynos5_dmc *dmc,
return 0;
err_free_tables:
- kfree(dmc->opp);
+ devm_kfree(dmc->dev, dmc->opp);
err_opp:
dev_pm_opp_of_remove_table(dmc->dev);
@@ -732,7 +732,7 @@ static struct devfreq_dev_profile exynos5_dmc_df_profile = {
* statistics engine which supports only registered values. Thus, some alignment
* must be made.
*/
-unsigned long
+static unsigned long
exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc,
unsigned long bootloader_init_freq)
{
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190916100716eucas1p213ef29ba8bd288dfc6b5f05138c9a558@eucas1p2.samsung.com>
2019-09-16 10:07 ` [PATCH v2 0/3] Exynos5 DMC minor fixes Lukasz Luba
2019-09-16 10:07 ` Lukasz Luba [this message]
2019-09-18 18:55 ` [PATCH v2 1/3] memory: Exynos5422: minor fixes in DMC Krzysztof Kozlowski
2019-09-16 10:07 ` [PATCH v2 2/3] ARM: dts: exynos: fix too long line in memory device Lukasz Luba
2019-09-18 18:55 ` Krzysztof Kozlowski
2019-09-16 10:07 ` [PATCH v2 3/3] dt-bindings: ddr: Add bindings for Samsung LPDDR3 memories Lukasz Luba
2019-09-18 18:51 ` Krzysztof Kozlowski
2019-09-19 6:49 ` Lukasz Luba
2019-09-19 7:28 ` Krzysztof Kozlowski
2019-09-19 7:43 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916100704.26692-2-l.luba@partner.samsung.com \
--to=l.luba@partner$(echo .)samsung.com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=kgene@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=myungjoo.ham@samsung$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.nawrocki@samsung$(echo .)com \
--cc=willy.mh.wolff.ml@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox