From: Brian Masney <masneyb@onstation•org>
To: Enric Balletbo i Serra <enric.balletbo@collabora•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
jernej.skrabec@siol•net, narmstrong@baylibre•com,
airlied@linux•ie, linux-kernel@vger•kernel.org,
linus.walleij@linaro•org, jonas@kwiboo•se, agross@kernel•org,
dri-devel@lists•freedesktop.org, bjorn.andersson@linaro•org,
Andrzej Hajda <a.hajda@samsung•com>,
robdclark@gmail•com, robh+dt@kernel•org,
Laurent.pinchart@ideasonboard•com, daniel@ffwll•ch,
linux-arm-msm@vger•kernel.org, freedreno@lists•freedesktop.org,
sean@poorly•run, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0
Date: Mon, 16 Sep 2019 06:40:04 -0400 [thread overview]
Message-ID: <20190916104004.GB1644@onstation.org> (raw)
In-Reply-To: <98199a9b-f7e0-ef95-62d7-401273457692@collabora.com>
On Mon, Sep 16, 2019 at 12:36:19PM +0200, Enric Balletbo i Serra wrote:
> Hi Andrzej and Brian
>
> On 16/9/19 12:02, Andrzej Hajda wrote:
> > On 15.08.2019 02:48, Brian Masney wrote:
> >> When attempting to configure this driver on a Nexus 5 phone (msm8974),
> >> setting up the dummy i2c bus for TX_P0 would fail due to an -EBUSY
> >> error. The downstream MSM kernel sources [1] shows that the proper value
> >> for TX_P0 is 0x78, not 0x70, so correct the value to allow device
> >> probing to succeed.
> >>
> >> [1] https://github.com/AICP/kernel_lge_hammerhead/blob/n7.1/drivers/video/slimport/slimport_tx_reg.h
> >>
> >> Signed-off-by: Brian Masney <masneyb@onstation•org>
> >> ---
> >> drivers/gpu/drm/bridge/analogix-anx78xx.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.h b/drivers/gpu/drm/bridge/analogix-anx78xx.h
> >> index 25e063bcecbc..bc511fc605c9 100644
> >> --- a/drivers/gpu/drm/bridge/analogix-anx78xx.h
> >> +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.h
> >> @@ -6,7 +6,7 @@
> >> #ifndef __ANX78xx_H
> >> #define __ANX78xx_H
> >>
> >> -#define TX_P0 0x70
> >> +#define TX_P0 0x78
> >
> >
> > This bothers me little. There are no upstream users, grepping android
> > sources suggests that both values can be used [1][2] (grep for "#define
> > TX_P0"), moreover there is code suggesting both values can be valid [3].
> >
> > Could you verify datasheet which i2c slave addresses are valid for this
> > chip, if both I guess this patch should be reworked.
> >
>
> On my case the valid i2c slave address is 0x70 (from datasheet, very sorry I
> can't share it) and the bridge used is an ANX7814, it could be that ANX7808 or
> ANX7812 have different slave addresses?
I haven't been able to find any of the datasheets for these devices
online. Product briefs are online (such as
https://www.analogix.com/en/system/files/ANX7808_product_brief.pdf), but
they don't provide this type of information.
Brian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 10:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190815004916epcas3p4d8a62e215eff5e227721d3449e6bfbd3@epcas3p4.samsung.com>
2019-08-15 0:48 ` [PATCH 00/11] ARM: dts: qcom: msm8974: add support for external display Brian Masney
2019-08-15 0:48 ` [PATCH 01/11] dt-bindings: drm/bridge: analogix-anx78xx: add new variants Brian Masney
2019-08-15 8:17 ` Linus Walleij
2019-08-27 16:20 ` Rob Herring
2019-08-15 0:48 ` [PATCH 02/11] " Brian Masney
2019-08-15 8:17 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 03/11] drm/bridge: analogix-anx78xx: silence -EPROBE_DEFER warnings Brian Masney
2019-08-15 8:35 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 04/11] drm/bridge: analogix-anx78xx: convert to i2c_new_dummy_device Brian Masney
2019-08-15 8:18 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0 Brian Masney
2019-08-15 8:24 ` Linus Walleij
2019-09-16 10:02 ` Andrzej Hajda
2019-09-16 10:36 ` Brian Masney
2019-09-16 10:49 ` Laurent Pinchart
2019-09-16 11:32 ` Enric Balletbo i Serra
2019-09-16 12:02 ` Brian Masney
2019-09-16 12:25 ` Andrzej Hajda
2019-09-17 7:28 ` Andrzej Hajda
2019-09-16 10:36 ` Enric Balletbo i Serra
2019-09-16 10:40 ` Brian Masney [this message]
2019-08-15 0:48 ` [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator Brian Masney
2019-08-15 8:22 ` Linus Walleij
2019-08-15 22:51 ` Brian Masney
2019-08-15 0:48 ` [PATCH 07/11] ARM: qcom_defconfig: add CONFIG_DRM_ANALOGIX_ANX78XX Brian Masney
2019-08-15 8:23 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 08/11] drm/msm/hdmi: silence -EPROBE_DEFER warning Brian Masney
2019-08-15 8:35 ` Linus Walleij
2019-08-15 0:48 ` [PATCH 09/11] ARM: dts: qcom: pm8941: add 5vs2 regulator node Brian Masney
2019-08-15 8:34 ` Linus Walleij
2019-08-15 22:44 ` Brian Masney
2019-08-15 0:48 ` [PATCH RFC 10/11] ARM: dts: qcom: msm8974: add HDMI nodes Brian Masney
2019-08-15 8:25 ` Linus Walleij
2019-08-15 0:48 ` [PATCH RFC 11/11] ARM: dts: qcom: msm8974-hammerhead: add support for external display Brian Masney
2019-08-15 8:31 ` Linus Walleij
2019-09-16 8:13 ` [PATCH 00/11] ARM: dts: qcom: msm8974: " Andrzej Hajda
2019-09-16 9:01 ` Brian Masney
2019-09-16 12:02 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916104004.GB1644@onstation.org \
--to=masneyb@onstation$(echo .)org \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=a.hajda@samsung$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=jernej.skrabec@siol$(echo .)net \
--cc=jonas@kwiboo$(echo .)se \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=robdclark@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sean@poorly$(echo .)run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox