From: Steven Rostedt <rostedt@goodmis•org>
To: Qian Cai <cai@lca•pw>
Cc: Petr Mladek <pmladek@suse•com>, Theodore Ts'o <tytso@mit•edu>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail•com>,
Arnd Bergmann <arnd@arndb•de>,
Peter Zijlstra <peterz@infradead•org>,
Catalin Marinas <catalin.marinas@arm•com>,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Waiman Long <longman@redhat•com>,
Dan Williams <dan.j.williams@intel•com>,
Will Deacon <will@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org
Subject: Re: page_alloc.shuffle=1 + CONFIG_PROVE_LOCKING=y = arm64 hang
Date: Mon, 16 Sep 2019 10:42:39 -0400 [thread overview]
Message-ID: <20190916104239.124fc2e5@gandalf.local.home> (raw)
In-Reply-To: <1568289941.5576.140.camel@lca.pw>
On Thu, 12 Sep 2019 08:05:41 -0400
Qian Cai <cai@lca•pw> wrote:
> > drivers/char/random.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/char/random.c b/drivers/char/random.c
> > index 9b54cdb301d3..975015857200 100644
> > --- a/drivers/char/random.c
> > +++ b/drivers/char/random.c
> > @@ -1687,8 +1687,9 @@ static void _warn_unseeded_randomness(const char *func_name, void *caller,
> > print_once = true;
> > #endif
> > if (__ratelimit(&unseeded_warning))
> > - pr_notice("random: %s called from %pS with crng_init=%d\n",
> > - func_name, caller, crng_init);
> > + printk_deferred(KERN_NOTICE "random: %s called from %pS "
> > + "with crng_init=%d\n", func_name, caller,
> > + crng_init);
> > }
> >
> > /*
> > @@ -2462,4 +2463,4 @@ void add_bootloader_randomness(const void *buf, unsigned int size)
> > else
> > add_device_randomness(buf, size);
> > }
> > -EXPORT_SYMBOL_GPL(add_bootloader_randomness);
> > \ No newline at end of file
> > +EXPORT_SYMBOL_GPL(add_bootloader_randomness);
>
> This will also fix the hang.
>
> Sergey, do you plan to submit this Ted?
Perhaps for a quick fix (and a comment that says this needs to be fixed
properly). I think the changes to printk() that was discussed at
Plumbers may also solve this properly.
-- Steve
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-16 14:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 21:33 page_alloc.shuffle=1 + CONFIG_PROVE_LOCKING=y = arm64 hang Qian Cai
2019-08-23 11:37 ` Will Deacon
2019-08-23 11:52 ` Qian Cai
2019-09-05 21:08 ` Qian Cai
2019-09-10 15:22 ` Qian Cai
2019-09-10 19:49 ` Qian Cai
2019-09-12 2:28 ` CONFIG_SHUFFLE_PAGE_ALLOCATOR=y lockdep splat (WAS Re: page_alloc.shuffle=1 + CONFIG_PROVE_LOCKING=y = arm64 hang) Qian Cai
2019-09-10 20:35 ` page_alloc.shuffle=1 + CONFIG_PROVE_LOCKING=y = arm64 hang Qian Cai
2019-09-11 1:10 ` Sergey Senozhatsky
2019-09-12 12:05 ` Qian Cai
2019-09-16 14:42 ` Steven Rostedt [this message]
2019-09-17 0:53 ` Sergey Senozhatsky
2019-09-18 14:39 ` printk() + memory offline deadlock (WAS Re: page_alloc.shuffle=1 + CONFIG_PROVE_LOCKING=y = arm64 hang) Qian Cai
2019-09-18 15:50 ` Sergey Senozhatsky
2019-09-18 15:58 ` Sergey Senozhatsky
2019-09-18 16:10 ` Qian Cai
2019-09-23 10:21 ` Sergey Senozhatsky
2019-09-23 12:58 ` Petr Mladek
2019-09-23 13:24 ` Qian Cai
2019-09-24 1:28 ` Sergey Senozhatsky
2019-09-23 13:09 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916104239.124fc2e5@gandalf.local.home \
--to=rostedt@goodmis$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=cai@lca$(echo .)pw \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=longman@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=sergey.senozhatsky.work@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tytso@mit$(echo .)edu \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox