From: Krzysztof Kozlowski <krzk@kernel•org>
To: Sylwester Nawrocki <s.nawrocki@samsung•com>
Cc: devicetree@vger•kernel.org, alsa-devel@alsa-project•org,
linux-samsung-soc@vger•kernel.org, ckeepax@opensource•cirrus.com,
b.zolnierkie@samsung•com, sbkim73@samsung•com,
patches@opensource•cirrus.com, lgirdwood@gmail•com,
robh+dt@kernel•org, broonie@kernel•org,
linux-arm-kernel@lists•infradead.org, m.szyprowski@samsung•com
Subject: Re: [PATCH v1 1/9] ASoC: wm8994: Do not register inapplicable controls for WM1811
Date: Thu, 19 Sep 2019 09:38:32 +0200 [thread overview]
Message-ID: <20190919073832.GA13195@pi3> (raw)
In-Reply-To: <20190918104634.15216-2-s.nawrocki@samsung.com>
On Wed, Sep 18, 2019 at 12:46:26PM +0200, Sylwester Nawrocki wrote:
> In case of WM1811 device there are currently being registered controls
> referring to registers not existing on that device.
> It has been noticed when getting values of "AIF1ADC2 Volume", "AIF1DAC2
> Volume" controls was failing during ALSA state restoring at boot time:
> "amixer: Mixer hw:0 load error: Device or resource busy"
>
> Reading some registers through I2C was failing with EBUSY error and indeed
> those registers were not available according to the datasheet.
>
> To fix this controls not available on WM1811 are moved to a separate array
> and registered only for WM8994 and WM8958.
>
> There are some further differences between WM8994 and WM1811, e.g. registers
> 603h, 604h, 605h, which are not covered in this patch.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
> ---
> sound/soc/codecs/wm8994.c | 43 +++++++++++++++++++++++----------------
> 1 file changed, 26 insertions(+), 17 deletions(-)
Acked-by: Krzysztof Kozlowski <krzk@kernel•org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-19 7:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190918104650eucas1p2288b0b7e8081e872c4f181cb5ca8ba0d@eucas1p2.samsung.com>
2019-09-18 10:46 ` [PATCH v1 0/9] Basic sound support for Arndale board / wm8994 updates Sylwester Nawrocki
2019-09-18 10:46 ` [PATCH v1 1/9] ASoC: wm8994: Do not register inapplicable controls for WM1811 Sylwester Nawrocki
2019-09-18 12:51 ` Charles Keepax
2019-09-19 7:38 ` Krzysztof Kozlowski [this message]
2019-09-18 10:46 ` [PATCH v1 2/9] mfd: wm8994: Add support for MCLKn clock control Sylwester Nawrocki
2019-09-18 10:59 ` Sylwester Nawrocki
2019-09-18 12:54 ` Charles Keepax
2019-09-18 13:36 ` Sylwester Nawrocki
2019-09-19 7:59 ` Krzysztof Kozlowski
2019-09-19 12:48 ` Sylwester Nawrocki
2019-09-19 13:07 ` Krzysztof Kozlowski
2019-09-19 12:50 ` Mark Brown
2019-09-19 14:31 ` Charles Keepax
2019-09-19 14:33 ` Mark Brown
2019-09-18 10:46 ` [PATCH v1 3/9] ASoC: wm8994: Add support for setting MCLKn clock rate Sylwester Nawrocki
2019-09-18 13:51 ` Charles Keepax
2019-09-19 8:00 ` Krzysztof Kozlowski
2019-09-18 10:46 ` [PATCH v1 4/9] ASoC: wm8994: Add support for MCLKn clock gating Sylwester Nawrocki
2019-09-18 14:31 ` Charles Keepax
2019-09-19 11:58 ` Sylwester Nawrocki
2019-09-19 14:33 ` Charles Keepax
2019-09-18 10:46 ` [PATCH v1 5/9] ASoC: samsung: arndale: Simplify DAI link initialization Sylwester Nawrocki
2019-09-18 14:33 ` Charles Keepax
2019-09-19 8:01 ` Krzysztof Kozlowski
2019-09-18 10:46 ` [PATCH v1 6/9] ASoC: dt-bindings: Document "samsung,arndale-wm1811" compatible Sylwester Nawrocki
2019-09-19 8:02 ` Krzysztof Kozlowski
2019-09-18 10:46 ` [PATCH v1 7/9] ASoC: samsung: arndale: Add support for WM1811 CODEC Sylwester Nawrocki
2019-09-18 14:45 ` Charles Keepax
2019-09-19 12:00 ` Sylwester Nawrocki
2019-09-18 10:46 ` [PATCH v1 8/9] ASoC: samsung: arndale: Add missing OF node dereferencing Sylwester Nawrocki
2019-09-18 14:51 ` Charles Keepax
2019-09-19 8:22 ` Krzysztof Kozlowski
2019-09-19 12:49 ` Sylwester Nawrocki
2019-09-19 12:58 ` Krzysztof Kozlowski
2019-09-19 13:31 ` [alsa-devel] " Sylwester Nawrocki
2019-09-18 10:46 ` [PATCH v1 9/9] ARM: dts: arndale: Add audio support (WM1811 CODEC boards) Sylwester Nawrocki
2019-09-19 8:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919073832.GA13195@pi3 \
--to=krzk@kernel$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=ckeepax@opensource$(echo .)cirrus.com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=patches@opensource$(echo .)cirrus.com \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.nawrocki@samsung$(echo .)com \
--cc=sbkim73@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox