From: "Artur Świgoń" <a.swigon@samsung•com>
To: devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-samsung-soc@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-pm@vger•kernel.org, dri-devel@lists•freedesktop.org
Cc: "Artur Świgoń" <a.swigon@partner•samsung.com>,
b.zolnierkie@samsung•com, sw0312.kim@samsung•com,
krzk@kernel•org, inki.dae@samsung•com, cw00.choi@samsung•com,
myungjoo.ham@samsung•com, leonard.crestez@nxp•com,
georgi.djakov@linaro•org, m.szyprowski@samsung•com
Subject: [RFC PATCH v2 03/11] devfreq: exynos-bus: Change goto-based logic to if-else logic
Date: Thu, 19 Sep 2019 16:22:28 +0200 [thread overview]
Message-ID: <20190919142236.4071-4-a.swigon@samsung.com> (raw)
In-Reply-To: <20190919142236.4071-1-a.swigon@samsung.com>
From: Artur Świgoń <a.swigon@partner•samsung.com>
This patch improves code readability by changing the following construct:
> if (cond)
> goto passive;
> foo();
> goto out;
>passive:
> bar();
>out:
into this:
> if (cond)
> bar();
> else
> foo();
Signed-off-by: Artur Świgoń <a.swigon@partner•samsung.com>
---
drivers/devfreq/exynos-bus.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index f85bed241631..60ad4319fd80 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -420,19 +420,13 @@ static int exynos_bus_probe(struct platform_device *pdev)
goto err_reg;
if (passive)
- goto passive;
+ ret = exynos_bus_profile_init_passive(bus, profile);
+ else
+ ret = exynos_bus_profile_init(bus, profile);
- ret = exynos_bus_profile_init(bus, profile);
if (ret < 0)
goto err;
- goto out;
-passive:
- ret = exynos_bus_profile_init_passive(bus, profile);
- if (ret < 0)
- goto err;
-
-out:
max_state = bus->devfreq->profile->max_state;
min_freq = (bus->devfreq->profile->freq_table[0] / 1000);
max_freq = (bus->devfreq->profile->freq_table[max_state - 1] / 1000);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-19 14:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190919142321eucas1p164c2591ad402427cb71fd00c348a29ec@eucas1p1.samsung.com>
2019-09-19 14:22 ` [RFC PATCH v2 00/11] Simple QoS for exynos-bus driver using interconnect Artur Świgoń
2019-09-19 14:22 ` [RFC PATCH v2 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init() Artur Świgoń
2019-09-20 2:15 ` Chanwoo Choi
2019-09-25 5:44 ` Artur Świgoń
2019-09-25 6:37 ` Chanwoo Choi
2019-09-25 6:41 ` Artur Świgoń
2019-09-19 14:22 ` [RFC PATCH v2 02/11] devfreq: exynos-bus: Extract exynos_bus_profile_init_passive() Artur Świgoń
2019-09-19 14:22 ` Artur Świgoń [this message]
2019-09-19 14:22 ` [RFC PATCH v2 04/11] devfreq: exynos-bus: Clean up code Artur Świgoń
2019-09-20 2:22 ` Chanwoo Choi
2019-10-03 8:10 ` Artur Świgoń
2019-09-19 14:22 ` [RFC PATCH v2 05/11] interconnect: Export of_icc_get_from_provider() Artur Świgoń
2019-12-16 0:57 ` Chanwoo Choi
2019-09-19 14:22 ` [RFC PATCH v2 06/11] interconnect: Relax requirement in of_icc_get_from_provider() Artur Świgoń
2019-09-19 14:22 ` [RFC PATCH v2 07/11] interconnect: Relax condition in apply_constraints() Artur Świgoń
2019-09-19 14:22 ` [RFC PATCH v2 08/11] arm: dts: exynos: Add parents and #interconnect-cells to Exynos4412 Artur Świgoń
2019-12-16 0:51 ` Chanwoo Choi
2019-12-16 2:59 ` Chanwoo Choi
2019-12-18 10:17 ` Artur Świgoń
2019-12-18 10:29 ` Chanwoo Choi
2019-12-18 10:41 ` Artur Świgoń
2019-12-16 0:55 ` Chanwoo Choi
2019-12-16 0:57 ` Chanwoo Choi
2019-09-19 14:22 ` [RFC PATCH v2 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus Artur Świgoń
2019-09-25 7:03 ` Chanwoo Choi
2019-09-25 7:12 ` Artur Świgoń
2019-12-02 17:05 ` Artur Świgoń
2019-12-05 2:36 ` Chanwoo Choi
2019-12-16 0:44 ` Chanwoo Choi
2019-12-18 10:18 ` Artur Świgoń
2019-12-18 10:39 ` Chanwoo Choi
2019-12-18 10:48 ` Artur Świgoń
2019-12-18 11:08 ` Chanwoo Choi
2019-09-19 14:22 ` [RFC PATCH v2 10/11] arm: dts: exynos: Add interconnects to Exynos4412 mixer Artur Świgoń
2019-09-19 14:22 ` [RFC PATCH v2 11/11] drm: exynos: mixer: Add interconnect support Artur Świgoń
2019-09-20 1:07 ` [RFC PATCH v2 00/11] Simple QoS for exynos-bus driver using interconnect Chanwoo Choi
2019-09-20 2:14 ` Chanwoo Choi
2019-09-25 5:47 ` Artur Świgoń
2019-09-25 6:12 ` Chanwoo Choi
2019-09-25 6:37 ` Artur Świgoń
2019-09-25 6:48 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919142236.4071-4-a.swigon@samsung.com \
--to=a.swigon@samsung$(echo .)com \
--cc=a.swigon@partner$(echo .)samsung.com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=georgi.djakov@linaro$(echo .)org \
--cc=inki.dae@samsung$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=leonard.crestez@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=myungjoo.ham@samsung$(echo .)com \
--cc=sw0312.kim@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox