From: Pavel Machek <pavel@ucw•cz>
To: Anson Huang <Anson.Huang@nxp•com>
Cc: mark.rutland@arm•com, ulf.hansson@linaro•org, ping.bai@nxp•com,
catalin.marinas@arm•com, peng.fan@nxp•com, stefan@agner•ch,
bjorn.andersson@linaro•org, leonard.crestez@nxp•com,
will@kernel•org, festevam@gmail•com, yuehaibing@huawei•com,
marcin.juszkiewicz@linaro•org, jagan@amarulasolutions•com,
linux-input@vger•kernel.org, ronald@innovation•ch,
Linux-imx@nxp•com, devicetree@vger•kernel.org, arnd@arndb•de,
s.hauer@pengutronix•de, mripard@kernel•org,
m.felsch@pengutronix•de, robh+dt@kernel•org, tglx@linutronix•de,
andriy.shevchenko@linux•intel.com, daniel.baluta@nxp•com,
linux-arm-kernel@lists•infradead.org, aisheng.dong@nxp•com,
fugang.duan@nxp•com, gregkh@linuxfoundation•org,
dmitry.torokhov@gmail•com, linux-kernel@vger•kernel.org,
dinguyen@kernel•org, kernel@pengutronix•de, olof@lixom•net,
shawnguo@kernel•org
Subject: Re: [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding
Date: Sun, 22 Sep 2019 18:13:47 +0200 [thread overview]
Message-ID: <20190922161347.GB1999@bug> (raw)
In-Reply-To: <1567519424-32271-1-git-send-email-Anson.Huang@nxp.com>
Hi!
> NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as
> system controller, the system controller is in charge of system
> power, clock and power key event etc. management, Linux kernel
> has to communicate with system controller via MU (message unit)
> IPC to get power key event, add binding doc for i.MX system
> controller power key driver.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp•com>
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -157,6 +157,15 @@ Required properties:
> Optional properties:
> - timeout-sec: contains the watchdog timeout in seconds.
>
> +Power key bindings based on SCU Message Protocol
> +------------------------------------------------------------
> +
> +Required properties:
> +- compatible: should be:
> + "fsl,imx8qxp-sc-pwrkey"
> + followed by "fsl,imx-sc-pwrkey";
> +- linux,keycodes: See Documentation/devicetree/bindings/input/keys.txt
Actually there's no reason for having "linux,keycodes" property when it is always
a power button.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-22 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 14:03 [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:55 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support Anson Huang
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 3:11 ` Anson Huang
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:48 ` Anson Huang
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:43 ` Oleksij Rempel
2019-09-22 16:14 ` Pavel Machek
2019-09-03 14:03 ` [PATCH V2 3/5] arm64: dts: imx8qxp: Add scu power key node Anson Huang
2019-09-03 14:03 ` [PATCH V2 4/5] arm64: dts: imx8qxp-mek: Enable scu power key Anson Huang
2019-09-03 14:03 ` [PATCH V2 5/5] arm64: defconfig: Enable CONFIG_KEYBOARD_IMX_SC_PWRKEY as module Anson Huang
2019-09-22 16:13 ` Pavel Machek [this message]
2019-09-23 2:31 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang
2019-09-22 16:14 ` Pavel Machek
2019-09-23 2:34 ` Anson Huang
2019-10-06 0:32 ` Shawn Guo
2019-10-07 1:29 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922161347.GB1999@bug \
--to=pavel@ucw$(echo .)cz \
--cc=Anson.Huang@nxp$(echo .)com \
--cc=Linux-imx@nxp$(echo .)com \
--cc=aisheng.dong@nxp$(echo .)com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=arnd@arndb$(echo .)de \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=daniel.baluta@nxp$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dinguyen@kernel$(echo .)org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=fugang.duan@nxp$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jagan@amarulasolutions$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=leonard.crestez@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=marcin.juszkiewicz@linaro$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=peng.fan@nxp$(echo .)com \
--cc=ping.bai@nxp$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=ronald@innovation$(echo .)ch \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=stefan@agner$(echo .)ch \
--cc=tglx@linutronix$(echo .)de \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox