Subject: Re: [PATCH] mfd: mt6360: add pmic mt6360 driver

From: Lee Jones <[email-masked]>
Date: Tue, 24 Sep 2019 21:38:48 +0100

On Tue, 24 Sep 2019, Gene Chen wrote:

> 2019-09-19 15:18 GMT+08:00, Lee Jones <[email-masked]>:
> > On Thu, 19 Sep 2019, Gene Chen wrote:
> >
> >> Lee Jones <[email-masked]> 於 2019年9月18日 週三 下午6:51寫道：
> >> >
> >> > On Wed, 18 Sep 2019, Gene Chen wrote:
> >> >
> >> > > From: Gene Chen <[email-masked]>
> >> > >
> >> > > Add mfd driver for mt6360 pmic chip include
> >> > > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck
> >> > >
> >> > > Signed-off-by: Gene Chen <[email-masked]
> >> > > ---
> >> >
> >> > This looks different from the one you sent before, but I don't see a
> >> > version bump or any changelog in this space.  Please re-submit with
> >> > the differences noted.
> >> >
> >>
> >> the change is
> >> 1. add missing include file
> >> 2. modify commit message
> >>
> >> this patch is regarded as version 1
> >
> > It's different to the first one you sent to the list, so it needs a
> > version bump and a change log.  There also appears to still be issues
> > with it, if the auto-builders are to be believed.
> >
> > Do ensure you thoroughly test your patches before sending upstream.
> >
> > Please fix the issues and resubmit your v3 with a nice changelog.
> >
> 
> thank you for suggestion
> may i ask how to disable kbuild test reboot for s390/x86_64/ia64?
> we want support only cross compiler =  aarch64-linux-gnu-
> and we have test build pass with our patch

You can't and we wouldn't want to.

If this driver should only be built/tested for AArch64, you need to
ensure the Kconfig represents that.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel