From: Andrew Murray <andrew.murray@arm•com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin•com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
linux-pci@vger•kernel.org, linux-kernel@vger•kernel.org,
Remi Pommarel <repk@triplefau•lt>,
Bjorn Helgaas <bhelgaas@google•com>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding spinlock
Date: Mon, 30 Sep 2019 15:49:59 +0100 [thread overview]
Message-ID: <20190930144958.GA42880@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190927114555.193a9d68@windsurf>
On Fri, Sep 27, 2019 at 11:45:55AM +0200, Thomas Petazzoni wrote:
> On Fri, 27 Sep 2019 10:55:02 +0200
> Remi Pommarel <repk@triplefau•lt> wrote:
>
> > advk_pcie_wait_pio() can be called while holding a spinlock (from
> > pci_bus_read_config_dword()), then depends on jiffies in order to
> > timeout while polling on PIO state registers. In the case the PIO
> > transaction failed, the timeout will never happen and will also cause
> > the cpu to stall.
> >
> > This decrements a variable and wait instead of using jiffies.
> >
> > Signed-off-by: Remi Pommarel <repk@triplefau•lt>
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin•com>
>
Reviewed-by: Andrew Murray <andrew.murray@arm•com>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-30 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 8:55 [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding spinlock Remi Pommarel
2019-09-27 9:45 ` Thomas Petazzoni
2019-09-30 14:49 ` Andrew Murray [this message]
2019-10-15 11:16 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930144958.GA42880@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=repk@triplefau$(echo .)lt \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox