public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: Nick Desaulniers <ndesaulniers@google•com>
To: will@kernel•org
Cc: arnd@arndb•de, clang-built-linux@googlegroups•com,
	catalin.marinas@arm•com, linux@armlinux•org.uk,
	linux-kernel@vger•kernel.org, yamada.masahiro@socionext•com,
	linux-arm-kernel@lists•infradead.org,
	torvalds@linux-foundation•org, nsaenzjulienne@suse•de
Subject: Re: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"
Date: Tue,  1 Oct 2019 09:21:21 -0700	[thread overview]
Message-ID: <20191001162121.67109-1-ndesaulniers@google.com> (raw)
In-Reply-To: <20191001104253.fci7s3sn5ov3h56d@willie-the-truck>

> So you'd prefer I do something like the diff below?

Yes, I find that diff preferable.  Use __always_inline only when absolutely
necessary.  Even then, it sounds like this is a workaround for one compiler,
so it should probably also have a comment. (I don't mind changing this for
all compilers).

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2019-10-01 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 11:45 [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly" Will Deacon
2019-10-01  9:40 ` Masahiro Yamada
2019-10-01 10:42   ` Will Deacon
2019-10-01 11:41     ` Andrew Murray
2019-10-01 14:36       ` Russell King - ARM Linux admin
2019-10-01 15:28         ` Andrew Murray
2019-10-01 15:48           ` Russell King - ARM Linux admin
2019-10-01 16:14             ` Andrew Murray
2019-10-01 16:21     ` Nick Desaulniers [this message]
2019-10-01 17:12       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001162121.67109-1-ndesaulniers@google.com \
    --to=ndesaulniers@google$(echo .)com \
    --cc=arnd@arndb$(echo .)de \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=clang-built-linux@googlegroups$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=nsaenzjulienne@suse$(echo .)de \
    --cc=torvalds@linux-foundation$(echo .)org \
    --cc=will@kernel$(echo .)org \
    --cc=yamada.masahiro@socionext$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox