From: Dinh Nguyen <dinguyen@kernel•org>
To: linux@armlinux•org.uk
Cc: thor.thayer@linux•intel.com, linus.walleij@linaro•org,
linux-kernel@vger•kernel.org, dinguyen@kernel•org,
p.zabel@pengutronix•de, linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: drivers/amba: release the resource to allow for deferred probe
Date: Tue, 1 Oct 2019 16:40:26 -0500 [thread overview]
Message-ID: <20191001214026.21718-1-dinguyen@kernel.org> (raw)
With commit "79bdcb202a35 ARM: 8906/1: drivers/amba: add reset control to
amba bus probe", the amba bus driver needs to be deferred probe because the
reset driver is probed later than the amba bus. However with a deferred
probe, the call to request_resource() in the driver returns -EBUSY. The
reason is the driver has not released the resource from the previous probe
attempt.
This patch releases the resource when amba_device_try_add() returns
-EPROBE_DEFER. This allows the deferred probe to continue.
Fixes: 79bdcb202a35 ("ARM: 8906/1: drivers/amba: add reset control to
amba bus probe")
Signed-off-by: Dinh Nguyen <dinguyen@kernel•org>
---
drivers/amba/bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index f39f075abff9..f246b847c991 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -535,6 +535,7 @@ int amba_device_add(struct amba_device *dev, struct resource *parent)
if (ret == -EPROBE_DEFER) {
struct deferred_device *ddev;
+ release_resource(&dev->res);
ddev = kmalloc(sizeof(*ddev), GFP_KERNEL);
if (!ddev)
--
2.20.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-10-01 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 21:40 Dinh Nguyen [this message]
2019-10-01 21:50 ` [PATCH] ARM: drivers/amba: release the resource to allow for deferred probe Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001214026.21718-1-dinguyen@kernel.org \
--to=dinguyen@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=thor.thayer@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox