Subject: Re: [PATCH] arm64: errata: Update stale comment

From: Marc Zyngier <[email-masked]>
Date: Wed, 2 Oct 2019 14:20:24 +0100

On Mon, 23 Sep 2019 11:12:29 +0200
Thierry Reding <[email-masked]> wrote:

> From: Thierry Reding <[email-masked]>
> 
> Commit 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack
> thereof") renamed the caller of the install_bp_hardening_cb() function
> but forgot to update a comment, which can be confusing when trying to
> follow the code flow.
> 
> Fixes: 73f381660959 ("arm64: Advertise mitigation of Spectre-v2, or lack thereof")
> Signed-off-by: Thierry Reding <[email-masked]>
> ---
>  arch/arm64/kernel/cpu_errata.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> index 1e43ba5c79b7..f593f4cffc0d 100644
> --- a/arch/arm64/kernel/cpu_errata.c
> +++ b/arch/arm64/kernel/cpu_errata.c
> @@ -128,8 +128,8 @@ static void install_bp_hardening_cb(bp_hardening_cb_t fn,
>  	int cpu, slot = -1;
>  
>  	/*
> -	 * enable_smccc_arch_workaround_1() passes NULL for the hyp_vecs
> -	 * start/end if we're a guest. Skip the hyp-vectors work.
> +	 * detect_harden_bp_fw() passes NULL for the hyp_vecs start/end if
> +	 * we're a guest. Skip the hyp-vectors work.
>  	 */
>  	if (!hyp_vecs_start) {
>  		__this_cpu_write(bp_hardening_data.fn, fn);

Acked-by: Marc Zyngier <[email-masked]>

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel