Subject: Re: [PATCH] ARM: omap2plus_defconfig: Fix selected panels after generic panel changes

From: Laurent Pinchart <[email-masked]>
Date: Sun, 6 Oct 2019 17:53:48 +0300

Hi Nikolaus,

On Sat, Oct 05, 2019 at 12:50:37PM +0200, H. Nikolaus Schaller wrote:
> > Am 04.10.2019 um 10:41 schrieb Tomi Valkeinen <[email-masked]>:
> > 
> > On 03/10/2019 19:55, Tony Lindgren wrote:
> >> The old omapdrm panels got removed for v5.4 in favor of generic panels,
> >> and the Kconfig options changed. Let's update omap2plus_defconfig
> >> accordingly so the same panels are still enabled.
> >> Cc: Jyri Sarha <[email-masked]>
> >> Cc: Laurent Pinchart <[email-masked]>
> >> Cc: Tomi Valkeinen <[email-masked]>
> >> Signed-off-by: Tony Lindgren <[email-masked]>
> >> ---
> >>  arch/arm/configs/omap2plus_defconfig | 12 ++++++------
> >>  1 file changed, 6 insertions(+), 6 deletions(-)
> >> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> >> --- a/arch/arm/configs/omap2plus_defconfig
> >> +++ b/arch/arm/configs/omap2plus_defconfig
> >> @@ -356,14 +356,14 @@ CONFIG_DRM_OMAP_CONNECTOR_HDMI=m
> >>  CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV=m
> >>  CONFIG_DRM_OMAP_PANEL_DPI=m
> >>  CONFIG_DRM_OMAP_PANEL_DSI_CM=m
> >> -CONFIG_DRM_OMAP_PANEL_SONY_ACX565AKM=m
> >> -CONFIG_DRM_OMAP_PANEL_LGPHILIPS_LB035Q02=m
> >> -CONFIG_DRM_OMAP_PANEL_SHARP_LS037V7DW01=m
> >> -CONFIG_DRM_OMAP_PANEL_TPO_TD028TTEC1=m
> >> -CONFIG_DRM_OMAP_PANEL_TPO_TD043MTEA1=m
> >> -CONFIG_DRM_OMAP_PANEL_NEC_NL8048HL11=m
> >>  CONFIG_DRM_TILCDC=m
> >>  CONFIG_DRM_PANEL_SIMPLE=m
> >> +CONFIG_DRM_PANEL_LG_LB035Q02=m
> >> +CONFIG_DRM_PANEL_NEC_NL8048HL11=m
> >> +CONFIG_DRM_PANEL_SHARP_LS037V7DW01=m
> >> +CONFIG_DRM_PANEL_SONY_ACX565AKM=m
> >> +CONFIG_DRM_PANEL_TPO_TD028TTEC1=m
> >> +CONFIG_DRM_PANEL_TPO_TD043MTEA1=m
> >>  CONFIG_FB=y
> >>  CONFIG_FIRMWARE_EDID=y
> >>  CONFIG_FB_MODE_HELPERS=y
> > 
> > Sorry, I didn't remember to update these. Some additions:
> > 
> > These can be dropped, they no longer exist:
> > 
> > CONFIG_DRM_OMAP_ENCODER_TFP410=m
> > CONFIG_DRM_OMAP_CONNECTOR_DVI=m
> > CONFIG_DRM_OMAP_PANEL_DPI=m
> 
> After being hit by the __always_inline issue [1] I am now
> back with being able to test v5.4-rc1.
> 
> Now this patch fixes the build problem, but we still have
> one: panel drivers are no longer automatically loaded at
> boot. We now need to manually modprobe them.
> 
> This has been observed with GTA04 (TD028TTEC1) and OpenPandora
> (TD043MTEA1). So moving the drivers seems to have changed/broken
> something with DT based driver matching.

That's really weird, the driver name, the SPI device table and the OF
device table are the same (except for the "omapdss," prefix that we
don't add anymore in omapdss-boot-init.c). Would you be able to
investigate what broke ?

> [1]: https://lkml.org/lkml/2019/10/2/201

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel