From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
Alessandro Zummo <a.zummo@towertech•it>,
Lars-Peter Clausen <lars@metafoo•de>,
devicetree@vger•kernel.org, linux-iio@vger•kernel.org,
linux-pm@vger•kernel.org, Sebastian Reichel <sre@kernel•org>,
linux-kernel@vger•kernel.org, linux-samsung-soc@vger•kernel.org,
Rob Herring <robh+dt@kernel•org>, Kukjin Kim <kgene@kernel•org>,
Peter Meerwald-Stadler <pmeerw@pmeerw•net>,
Hartmut Knaack <knaack.h@gmx•de>,
linux-rtc@vger•kernel.org, Jonathan Cameron <jic23@kernel•org>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers
Date: Mon, 7 Oct 2019 15:17:36 +0200 [thread overview]
Message-ID: <20191007131736.GJ4254@piout.net> (raw)
In-Reply-To: <20191002160744.11307-2-krzk@kernel.org>
On 02/10/2019 18:07:42+0200, Krzysztof Kozlowski wrote:
> Make the examples in S3C RTC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin•com>
> ---
> Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> index 95570d7e19eb..4d91cdc9b998 100644
> --- a/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/s3c-rtc.yaml
> @@ -75,11 +75,14 @@ allOf:
>
> examples:
> - |
> + #include <dt-bindings/clock/exynos5420.h>
> + #include <dt-bindings/clock/samsung,s2mps11.h>
> +
> rtc@10070000 {
> compatible = "samsung,s3c6410-rtc";
> reg = <0x10070000 0x100>;
> interrupts = <0 44 4>, <0 45 4>;
> - clocks = <&clock 0>, // CLK_RTC
> - <&s2mps11_osc 0>; // S2MPS11_CLK_AP
> + clocks = <&clock CLK_RTC>,
> + <&s2mps11_osc S2MPS11_CLK_AP>;
> clock-names = "rtc", "rtc_src";
> };
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-07 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 16:07 [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Krzysztof Kozlowski
2019-10-02 16:07 ` [PATCH 2/4] dt-bindings: rtc: s3c: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni [this message]
2019-10-15 17:10 ` Rob Herring
2019-10-02 16:07 ` [PATCH 3/4] dt-bindings: rtc: s3c: Include generic dt-schema bindings Krzysztof Kozlowski
2019-10-07 13:17 ` Alexandre Belloni
2019-10-15 17:11 ` Rob Herring
2019-10-02 16:07 ` [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers Krzysztof Kozlowski
2019-10-06 10:02 ` Jonathan Cameron
2019-10-15 17:11 ` Rob Herring
2019-10-06 10:01 ` [PATCH 1/4] dt-bindings: samsung: Indent examples with four spaces Jonathan Cameron
2019-10-07 13:17 ` Alexandre Belloni
2019-10-10 16:48 ` Sebastian Reichel
2019-10-15 17:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007131736.GJ4254@piout.net \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=a.zummo@towertech$(echo .)it \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=jic23@kernel$(echo .)org \
--cc=kgene@kernel$(echo .)org \
--cc=knaack.h@gmx$(echo .)de \
--cc=krzk@kernel$(echo .)org \
--cc=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pmeerw@pmeerw$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=sre@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox