From: Steven Price <steven.price@arm•com>
To: linux-mm@kvack•org
Cc: "Mark Rutland" <Mark.Rutland@arm•com>,
x86@kernel•org, "Arnd Bergmann" <arnd@arndb•de>,
"Ard Biesheuvel" <ard.biesheuvel@linaro•org>,
"Peter Zijlstra" <peterz@infradead•org>,
"Catalin Marinas" <catalin.marinas@arm•com>,
"Dave Hansen" <dave.hansen@linux•intel.com>,
linux-kernel@vger•kernel.org,
"Steven Price" <steven.price@arm•com>,
"Jérôme Glisse" <jglisse@redhat•com>,
"Ingo Molnar" <mingo@redhat•com>,
"Borislav Petkov" <bp@alien8•de>,
"Andy Lutomirski" <luto@kernel•org>,
"H. Peter Anvin" <hpa@zytor•com>,
"James Morse" <james.morse@arm•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Will Deacon" <will@kernel•org>,
"Andrew Morton" <akpm@linux-foundation•org>,
linux-arm-kernel@lists•infradead.org, "Liang,
Kan" <kan.liang@linux•intel.com>
Subject: [PATCH v11 22/22] arm64: mm: Display non-present entries in ptdump
Date: Mon, 7 Oct 2019 16:38:22 +0100 [thread overview]
Message-ID: <20191007153822.16518-23-steven.price@arm.com> (raw)
In-Reply-To: <20191007153822.16518-1-steven.price@arm.com>
Previously the /sys/kernel/debug/kernel_page_tables file would only show
lines for entries present in the page tables. However it is useful to
also show non-present entries as this makes the size and level of the
holes more visible. This aligns the behaviour with x86 which also shows
holes.
Signed-off-by: Steven Price <steven.price@arm•com>
---
arch/arm64/mm/dump.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index 9d9b740a86d2..3203dd8e6d0a 100644
--- a/arch/arm64/mm/dump.c
+++ b/arch/arm64/mm/dump.c
@@ -269,21 +269,22 @@ static void note_page(struct ptdump_state *pt_st, unsigned long addr, int level,
if (st->current_prot) {
note_prot_uxn(st, addr);
note_prot_wx(st, addr);
- pt_dump_seq_printf(st->seq, "0x%016lx-0x%016lx ",
+ }
+
+ pt_dump_seq_printf(st->seq, "0x%016lx-0x%016lx ",
st->start_address, addr);
- delta = (addr - st->start_address) >> 10;
- while (!(delta & 1023) && unit[1]) {
- delta >>= 10;
- unit++;
- }
- pt_dump_seq_printf(st->seq, "%9lu%c %s", delta, *unit,
- pg_level[st->level].name);
- if (pg_level[st->level].bits)
- dump_prot(st, pg_level[st->level].bits,
- pg_level[st->level].num);
- pt_dump_seq_puts(st->seq, "\n");
+ delta = (addr - st->start_address) >> 10;
+ while (!(delta & 1023) && unit[1]) {
+ delta >>= 10;
+ unit++;
}
+ pt_dump_seq_printf(st->seq, "%9lu%c %s", delta, *unit,
+ pg_level[st->level].name);
+ if (st->current_prot && pg_level[st->level].bits)
+ dump_prot(st, pg_level[st->level].bits,
+ pg_level[st->level].num);
+ pt_dump_seq_puts(st->seq, "\n");
if (addr >= st->marker[1].start_address) {
st->marker++;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-07 15:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 15:38 [PATCH v11 00/22] Generic page walk and ptdump Steven Price
2019-10-07 15:38 ` [PATCH v11 01/22] mm: Add generic p?d_leaf() macros Steven Price
2019-10-07 15:38 ` [PATCH v11 02/22] arc: mm: Add p?d_leaf() definitions Steven Price
2019-10-08 20:19 ` Vineet Gupta
2019-10-07 15:38 ` [PATCH v11 03/22] arm: " Steven Price
2019-10-07 15:38 ` [PATCH v11 04/22] arm64: " Steven Price
2019-10-07 15:38 ` [PATCH v11 05/22] mips: " Steven Price
2019-10-07 15:38 ` [PATCH v11 06/22] powerpc: " Steven Price
2019-10-07 15:38 ` [PATCH v11 07/22] riscv: " Steven Price
2019-10-08 11:31 ` Alex Ghiti
2019-10-08 21:33 ` Paul Walmsley
2019-10-09 10:55 ` Steven Price
2019-10-07 15:38 ` [PATCH v11 08/22] s390: " Steven Price
2019-10-07 15:38 ` [PATCH v11 09/22] sparc: " Steven Price
2019-10-07 15:38 ` [PATCH v11 10/22] x86: " Steven Price
2019-10-07 15:38 ` [PATCH v11 11/22] mm: pagewalk: Add p4d_entry() and pgd_entry() Steven Price
2019-10-07 15:38 ` [PATCH v11 12/22] mm: pagewalk: Allow walking without vma Steven Price
2019-10-07 15:38 ` [PATCH v11 13/22] mm: pagewalk: Add test_p?d callbacks Steven Price
2019-10-07 15:38 ` [PATCH v11 14/22] mm: pagewalk: Add 'depth' parameter to pte_hole Steven Price
2019-10-07 16:10 ` Jason Gunthorpe
2019-10-07 16:20 ` Steven Price
2019-10-07 18:11 ` Jason Gunthorpe
2019-10-09 11:00 ` Steven Price
2019-10-07 15:38 ` [PATCH v11 15/22] x86: mm: Point to struct seq_file from struct pg_state Steven Price
2019-10-07 15:38 ` [PATCH v11 16/22] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct Steven Price
2019-10-07 15:38 ` [PATCH v11 17/22] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct Steven Price
2019-10-07 15:38 ` [PATCH v11 18/22] x86: mm: Convert ptdump_walk_pgd_level_core() " Steven Price
2019-10-07 15:38 ` [PATCH v11 19/22] mm: Add generic ptdump Steven Price
2019-10-07 15:38 ` [PATCH v11 20/22] x86: mm: Convert dump_pagetables to use walk_page_range Steven Price
2019-10-07 15:38 ` [PATCH v11 21/22] arm64: mm: Convert mm/dump.c to use walk_page_range() Steven Price
2019-10-07 15:38 ` Steven Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007153822.16518-23-steven.price@arm.com \
--to=steven.price@arm$(echo .)com \
--cc=Mark.Rutland@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=hpa@zytor$(echo .)com \
--cc=james.morse@arm$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=kan.liang@linux$(echo .)intel.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=luto@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox