From: Sean Paul <sean@poorly•run>
To: Derek Basehore <dbasehore@chromium•org>
Cc: Philipp Zabel <p.zabel@pengutronix•de>,
Maxime Ripard <maxime.ripard@bootlin•com>,
Sam Ravnborg <sam@ravnborg•org>,
intel-gfx@lists•freedesktop.org,
Joonas Lahtinen <joonas.lahtinen@linux•intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux•intel.com>,
linux-kernel@vger•kernel.org,
Jani Nikula <jani.nikula@linux•intel.com>,
David Airlie <airlied@linux•ie>,
Thierry Reding <thierry.reding@gmail•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
dri-devel@lists•freedesktop.org, Daniel Vetter <daniel@ffwll•ch>,
Rodrigo Vivi <rodrigo.vivi@intel•com>, CK Hu <ck.hu@mediatek•com>,
linux-mediatek@lists•infradead.org, Sean Paul <sean@poorly•run>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v8 4/4] drm/mtk: add panel orientation property
Date: Mon, 7 Oct 2019 12:48:02 -0400 [thread overview]
Message-ID: <20191007164802.GD126146@art_vandelay> (raw)
In-Reply-To: <20190925225833.7310-5-dbasehore@chromium.org>
On Wed, Sep 25, 2019 at 03:58:33PM -0700, Derek Basehore wrote:
> This inits the panel orientation property for the mediatek dsi driver
> if the panel orientation (connector.display_info.panel_orientation) is
> not DRM_MODE_PANEL_ORIENTATION_UNKNOWN.
>
> Signed-off-by: Derek Basehore <dbasehore@chromium•org>
> Acked-by: Sam Ravnborg <sam@ravnborg•org>
> Reviewed-by: CK Hu <ck.hu@mediatek•com>
Reviewed-by: Sean Paul <seanpaul@chromium•org>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 224afb666881..2936932344eb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -792,10 +792,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)
> DRM_ERROR("Failed to attach panel to drm\n");
> goto err_connector_cleanup;
> }
> +
> + ret = drm_connector_init_panel_orientation_property(&dsi->conn);
> + if (ret) {
> + DRM_ERROR("Failed to init panel orientation\n");
> + goto err_panel_detach;
> + }
> }
>
> return 0;
>
> +err_panel_detach:
> + drm_panel_detach(dsi->panel);
> err_connector_cleanup:
> drm_connector_cleanup(&dsi->conn);
> return ret;
> --
> 2.23.0.351.gc4317032e6-goog
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-07 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 22:58 [PATCH v8 0/4] Panel rotation patches Derek Basehore
2019-09-25 22:58 ` [PATCH v8 1/4] drm/panel: Add helper for reading DT rotation Derek Basehore
2019-10-07 16:38 ` Sean Paul
2019-10-07 22:12 ` dbasehore .
2019-10-08 14:56 ` Sean Paul
2019-09-25 22:58 ` [PATCH v8 2/4] drm/panel: set display info in panel attach Derek Basehore
2019-09-29 5:23 ` [v8,2/4] " james qian wang (Arm Technology China)
2019-09-30 23:14 ` dbasehore .
2019-10-07 16:44 ` Sean Paul
2019-10-07 22:01 ` dbasehore .
2019-10-08 15:02 ` Sean Paul
2019-09-25 22:58 ` [PATCH v8 3/4] drm/connector: Split out orientation quirk detection Derek Basehore
2019-10-07 16:45 ` Sean Paul
2019-09-25 22:58 ` [PATCH v8 4/4] drm/mtk: add panel orientation property Derek Basehore
2019-10-07 16:48 ` Sean Paul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007164802.GD126146@art_vandelay \
--to=sean@poorly$(echo .)run \
--cc=airlied@linux$(echo .)ie \
--cc=ck.hu@mediatek$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dbasehore@chromium$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=maxime.ripard@bootlin$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=thierry.reding@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox