From: Jakub Kicinski <jakub.kicinski@netronome•com>
To: MarkLee <Mark-MC.Lee@mediatek•com>
Cc: Mark Rutland <mark.rutland@arm•com>, Andrew Lunn <andrew@lunn•ch>,
Nelson Chang <nelson.chang@mediatek•com>,
devicetree@vger•kernel.org, netdev@vger•kernel.org,
Sean Wang <sean.wang@mediatek•com>,
linux-kernel@vger•kernel.org,
Rene van Dorst <opensource@vdorst•com>,
Rob Herring <robh+dt@kernel•org>,
linux-mediatek@lists•infradead.org,
John Crispin <john@phrozen•org>,
Matthias Brugger <matthias.bgg@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH net,v2 1/2] net: ethernet: mediatek: Fix MT7629 missing GMII mode support
Date: Tue, 8 Oct 2019 16:06:43 -0700 [thread overview]
Message-ID: <20191008160643.1c1d31ff@cakuba.netronome.com> (raw)
In-Reply-To: <20191007070844.14212-2-Mark-MC.Lee@mediatek.com>
On Mon, 7 Oct 2019 15:08:43 +0800, MarkLee wrote:
> Add missing configuration for mt7629 gmii mode support
>
> Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII")
Thank you for adding the Fixes tag. It seem, however, that the patch in
question did not change the ge_mode setting. Is it because GMII now
makes a call to mtk_gmac_gephy_path_setup() that the different setting
is required? The Fixes tag should point to the commit which introduced
the wrong behaviour, it may be the initial commit of the driver if the
behaviour was always there.
Could you add more information to the patch description and perhaps
update Fixes tag if 7e538372694b didn't introduce the problem?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-08 23:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 7:08 [PATCH net,v2 0/2] Update MT7629 to support PHYLINK API MarkLee
2019-10-07 7:08 ` [PATCH net, v2 1/2] net: ethernet: mediatek: Fix MT7629 missing GMII mode support MarkLee
2019-10-07 18:29 ` [PATCH net,v2 " René van Dorst
2019-10-08 23:06 ` Jakub Kicinski [this message]
2019-10-07 7:08 ` [PATCH net, v2 2/2] arm: dts: mediatek: Fix mt7629 dts to reflect the latest dt-binding MarkLee
2019-10-07 18:30 ` [PATCH net,v2 " René van Dorst
2019-10-08 23:02 ` [PATCH net,v2 0/2] Update MT7629 to support PHYLINK API Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008160643.1c1d31ff@cakuba.netronome.com \
--to=jakub.kicinski@netronome$(echo .)com \
--cc=Mark-MC.Lee@mediatek$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=john@phrozen$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nelson.chang@mediatek$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opensource@vdorst$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sean.wang@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox