From: Russell King - ARM Linux admin <linux@armlinux•org.uk>
To: Ben Dooks <ben.dooks@codethink•co.uk>
Cc: linux-kernel@lists•codethink.co.uk,
Tony Lindgren <tony@atomide•com>,
linux-omap@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync
Date: Wed, 9 Oct 2019 17:14:24 +0100 [thread overview]
Message-ID: <20191009161423.GB1337@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191009133902.28405-1-ben.dooks@codethink.co.uk>
On Wed, Oct 09, 2019 at 02:39:02PM +0100, Ben Dooks wrote:
> Force the type of omap_interconnect_sync to avoid the
> following sparse warnign:
>
> arch/arm/mach-omap2/omap4-common.c:142:27: warning: incorrect type in assignment (different address spaces)
> arch/arm/mach-omap2/omap4-common.c:142:27: expected void [noderef] <asn:2> *static [toplevel] sram_sync
> arch/arm/mach-omap2/omap4-common.c:142:27: got void *
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
> ---
> Cc: Tony Lindgren <tony@atomide•com>
> Cc: Russell King <linux@armlinux•org.uk>
> Cc: linux-arm-kernel@lists•infradead.org
> Cc: linux-omap@vger•kernel.org
> ---
> arch/arm/mach-omap2/omap4-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
> index 5c3845730dbf..d27c5f61d708 100644
> --- a/arch/arm/mach-omap2/omap4-common.c
> +++ b/arch/arm/mach-omap2/omap4-common.c
> @@ -139,7 +139,7 @@ static int __init omap4_sram_init(void)
> pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
> __func__);
> else
> - sram_sync = (void *)gen_pool_alloc(sram_pool, PAGE_SIZE);
> + sram_sync = (void __force __iomem *)gen_pool_alloc(sram_pool, PAGE_SIZE);
Not sure about this one - did you check whether the memory returned
here really is iomem memory? If it isn't iomem memory, then the
warning should remain.
Never hide a valid sparse warning - to do so goes against the whole
point of sparse checks. It isn't "pointing out that a cast is missing,
we must add a cast", the point of sparse is to find and identify where
the code is actually incorrect - in other words, MMIO accessors are
used on memory that is not MMIO, or direct dereferences are used on
memory that is MMIO. If we go around merely casting the warnings away,
it makes sparse completely pointless.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-09 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:39 [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync Ben Dooks
2019-10-09 16:14 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009161423.GB1337@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=ben.dooks@codethink$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@lists$(echo .)codethink.co.uk \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox