From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: linux-arch@vger•kernel.org, Arnd Bergmann <arnd@arndb•de>,
linux-gpio@vger•kernel.org, yamada.masahiro@socionext•com,
linus.walleij@linaro•org, linux-pm@vger•kernel.org,
linux@rasmusvillemoes•dk,
William Breathitt Gray <vilhelm.gray@gmail•com>,
linux-kernel@vger•kernel.org, bgolaszewski@baylibre•com,
lukas@wunner•de, geert@linux-m68k•org, preid@electromag•com.au,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v18 01/14] bitops: Introduce the for_each_set_clump8 macro
Date: Thu, 10 Oct 2019 16:18:42 +0300 [thread overview]
Message-ID: <20191010131842.GT32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191009141855.310f1fa8bde58df0df27b8f0@linux-foundation.org>
On Wed, Oct 09, 2019 at 02:18:55PM -0700, Andrew Morton wrote:
> On Wed, 9 Oct 2019 13:14:37 -0400 William Breathitt Gray <vilhelm.gray@gmail•com> wrote:
>
> > This macro iterates for each 8-bit group of bits (clump) with set bits,
> > within a bitmap memory region. For each iteration, "start" is set to the
> > bit offset of the found clump, while the respective clump value is
> > stored to the location pointed by "clump". Additionally, the
> > bitmap_get_value8 and bitmap_set_value8 functions are introduced to
> > respectively get and set an 8-bit value in a bitmap memory region.
> >
> > ...
> >
> > +#define for_each_set_clump8(start, clump, bits, size) \
> > + for ((start) = find_first_clump8(&(clump), (bits), (size)); \
> > + (start) < (size); \
> > + (start) = find_next_clump8(&(clump), (bits), (size), (start) + 8))
> > +
>
> It wouldn't hurt to give this some documentation. In kerneldoc form, I
> guess.
Good idea!
William, I have just tested your series with a complex hardware setup,
everything works to me.
I think I may give
Tested-by: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
for this patch as well.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-10 13:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 17:14 [PATCH v18 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 01/14] bitops: " William Breathitt Gray
2019-10-09 21:18 ` Andrew Morton
2019-10-10 13:18 ` Andy Shevchenko [this message]
2019-10-09 17:14 ` [PATCH v18 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 04/14] gpio: 104-idi-48: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 05/14] gpio: gpio-mm: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 06/14] gpio: ws16c48: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 07/14] gpio: pci-idio-16: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 08/14] gpio: pcie-idio-24: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 09/14] gpio: uniphier: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 10/14] gpio: 74x164: Utilize the " William Breathitt Gray
2019-10-10 13:16 ` Andy Shevchenko
2019-10-09 17:14 ` [PATCH v18 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 12/14] gpio: pisosr: Utilize the " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 13/14] gpio: max3191x: " William Breathitt Gray
2019-10-09 17:14 ` [PATCH v18 14/14] gpio: pca953x: " William Breathitt Gray
2019-10-10 13:16 ` Andy Shevchenko
2019-10-09 17:38 ` [PATCH v18 00/14] Introduce " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010131842.GT32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=lukas@wunner$(echo .)de \
--cc=preid@electromag$(echo .)com.au \
--cc=vilhelm.gray@gmail$(echo .)com \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox