Subject: Re: [PATCH 1/1] ARM: dts: imx28: add poweroff support

From: Shawn Guo <[email-masked]>
Date: Mon, 14 Oct 2019 14:38:07 +0800

On Mon, Sep 23, 2019 at 11:17:00AM +0200, Sébastien Szymanski wrote:
> This add poweroff support using the generic syscon-poweroff driver.
> 
> Signed-off-by: Sébastien Szymanski <[email-masked]>
> ---
>  arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e14d8ef0158b..37fa8131a022 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -1114,8 +1114,16 @@
>  			};
>  
>  			power: power@80044000 {
> +				compatible = "syscon", "simple-mfd";
>  				reg = <0x80044000 0x2000>;
> -				status = "disabled";
> +
> +				mxs_poweroff: mxs-poweroff {

Node name should be generic.  So 'poweroff' might be better.

> +					compatible = "syscon-poweroff";
> +					regmap = <&power>;
> +					offset = <0x104>;
> +					value = <0x3E770001>;

Use lowercase for hex value.

> +					status = "disabled";

Why need to disable it by default?

Shawn

> +				};
>  			};
>  
>  			saif1: saif@80046000 {
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> [email-masked]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel