Subject: Re: [PATCH V6 1/2] mm/page_alloc: Make alloc_gigantic_page() available for general use

From: Michal Hocko <[email-masked]>
Date: Tue, 15 Oct 2019 13:47:23 +0200

On Tue 15-10-19 13:42:03, David Hildenbrand wrote:
[...]
> > -static bool pfn_range_valid_gigantic(struct zone *z,
> > -			unsigned long start_pfn, unsigned long nr_pages)
> > -{
> > -	unsigned long i, end_pfn = start_pfn + nr_pages;
> > -	struct page *page;
> > -
> > -	for (i = start_pfn; i < end_pfn; i++) {
> > -		if (!pfn_valid(i))
> > -			return false;
> > -
> > -		page = pfn_to_page(i);
> 
> Am I missing something or should here really be a pfn_to_online_page() here
> instead of a pfn_valid() ?

http://lkml.kernel.org/r/[email-masked]

-- 
Michal Hocko
SUSE Labs

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel