From: Florian Fainelli <f.fainelli@gmail•com>
To: linux-arm-kernel@lists•infradead.org
Cc: Florian Fainelli <f.fainelli@gmail•com>,
Vignesh Raghavendra <vigneshr@ti•com>,
Kamal Dasu <kdasu.kdev@gmail•com>,
Richard Weinberger <richard@nod•at>,
open list <linux-kernel@vger•kernel.org>,
Marek Vasut <marek.vasut@gmail•com>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<linux-mtd@lists•infradead.org>,
Miquel Raynal <miquel.raynal@bootlin•com>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<bcm-kernel-feedback-list@broadcom•com>,
Brian Norris <computersforpeace@gmail•com>,
David Woodhouse <dwmw2@infradead•org>
Subject: [PATCH v2] mtd: rawnand: brcmnand: Fix NULL pointer assignment
Date: Mon, 21 Oct 2019 09:45:54 -0700 [thread overview]
Message-ID: <20191021164555.5330-1-f.fainelli@gmail.com> (raw)
Sparse complained about the following:
drivers/mtd/nand/raw/brcmnand/brcmnand.c:921:40: warning: Using plain integer as NULL pointer
fix this issue by assigning the pointer to NULL.
Fixes: c1ac2dc34b51 ("mtd: rawnand: brcmnand: When oops in progress use pio and interrupt polling")
Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 15ef30b368a5..6a7f0211f5a5 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -918,7 +918,7 @@ static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl)
return;
if (has_flash_dma(ctrl)) {
- ctrl->flash_dma_base = 0;
+ ctrl->flash_dma_base = NULL;
disable_irq(ctrl->dma_irq);
}
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-10-21 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 16:45 Florian Fainelli [this message]
2019-10-30 8:24 ` [PATCH v2] mtd: rawnand: brcmnand: Fix NULL pointer assignment Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021164555.5330-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=computersforpeace@gmail$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=kdasu.kdev@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=marek.vasut@gmail$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox