From: Shawn Guo <shawnguo@kernel•org>
To: Anson Huang <anson.huang@nxp•com>
Cc: "mark.rutland@arm•com" <mark.rutland@arm•com>,
"baruch@tkos•co.il" <baruch@tkos•co.il>,
"dafna.hirschfeld@collabora•com" <dafna.hirschfeld@collabora•com>,
Jacky Bai <ping.bai@nxp•com>,
"ccaione@baylibre•com" <ccaione@baylibre•com>,
"agx@sigxcpu•org" <agx@sigxcpu•org>,
"angus@akkea•ca" <angus@akkea•ca>, Peng Fan <peng.fan@nxp•com>,
Gary Bisson <gary.bisson@boundarydevices•com>,
"pavel@ucw•cz" <pavel@ucw•cz>,
"manivannan.sadhasivam@linaro•org"
<manivannan.sadhasivam@linaro•org>,
Leonard Crestez <leonard.crestez@nxp•com>,
"festevam@gmail•com" <festevam@gmail•com>,
Richard Hu <richard.hu@technexion•com>,
Abel Vesa <abel.vesa@nxp•com>,
"andrew.smirnov@gmail•com" <andrew.smirnov@gmail•com>,
"daniel.lezcano@linaro•org" <daniel.lezcano@linaro•org>,
"jon@solid-run•com" <jon@solid-run•com>,
dl-linux-imx <linux-imx@nxp•com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"andradanciu1997@gmail•com" <andradanciu1997@gmail•com>,
"s.hauer@pengutronix•de" <s.hauer@pengutronix•de>,
Troy Kisky <troy.kisky@boundarydevices•com>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
Daniel Baluta <daniel.baluta@nxp•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
Aisheng Dong <aisheng.dong@nxp•com>,
Andy Duan <fugang.duan@nxp•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"kernel@pengutronix•de" <kernel@pengutronix•de>,
Jun Li <jun.li@nxp•com>,
"l.stach@pengutronix•de" <l.stach@pengutronix•de>
Subject: Re: [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to board DT
Date: Mon, 28 Oct 2019 11:15:00 +0800 [thread overview]
Message-ID: <20191028031459.GI16985@dragon> (raw)
In-Reply-To: <DB3PR0402MB3916A2258E1E8B4690CC1B7DF5660@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On Mon, Oct 28, 2019 at 01:29:32AM +0000, Anson Huang wrote:
> Hi, Shawn
>
> > On Wed, Oct 16, 2019 at 10:14:23AM +0800, Anson Huang wrote:
> > > usdhc's clock rate is different according to different devices
> > > connected, so clock rate assignment should be placed in board DT
> > > according to different devices connected on each usdhc port.
> >
> > I think it should be fine that we have a reasonable default settings in soc.dtsi,
> > and boards that need a different setup can overwrite the settings in
> > board.dts.
>
> Someone was complaining about the usdhc clock assignment in soc.dtsi, because some
> usdhc nodes are having clock assignments while some are NOT. That is why I did this
> patch set. I agree that we can have default settings in soc.dtsi, so do you think it makes
> sense to add default clock assignment to all usdhc nodes? If yes, I will redo the patch
> set.
I had a second thought on this. To ease the maintenance of soc.dtsi,
let's do clock assignments in board.dts.
Series applied, thanks.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-28 3:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 2:14 [PATCH 1/5] arm64: dts: imx8qxp: Move usdhc clocks assignment to board DT Anson Huang
2019-10-16 2:14 ` [PATCH 2/5] arm64: dts: imx8mq: " Anson Huang
2019-10-16 2:14 ` [PATCH 3/5] arm64: dts: imx8mm: " Anson Huang
2019-10-16 2:14 ` [PATCH 4/5] arm64: dts: imx8mn: " Anson Huang
2019-10-16 2:14 ` [PATCH 5/5] ARM: dts: imx7ulp: " Anson Huang
2019-10-20 14:35 ` [PATCH 1/5] arm64: dts: imx8qxp: " Abel Vesa
2019-10-26 12:09 ` Shawn Guo
2019-10-28 1:29 ` Anson Huang
2019-10-28 3:15 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028031459.GI16985@dragon \
--to=shawnguo@kernel$(echo .)org \
--cc=abel.vesa@nxp$(echo .)com \
--cc=agx@sigxcpu$(echo .)org \
--cc=aisheng.dong@nxp$(echo .)com \
--cc=andradanciu1997@gmail$(echo .)com \
--cc=andrew.smirnov@gmail$(echo .)com \
--cc=angus@akkea$(echo .)ca \
--cc=anson.huang@nxp$(echo .)com \
--cc=baruch@tkos$(echo .)co.il \
--cc=ccaione@baylibre$(echo .)com \
--cc=dafna.hirschfeld@collabora$(echo .)com \
--cc=daniel.baluta@nxp$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=fugang.duan@nxp$(echo .)com \
--cc=gary.bisson@boundarydevices$(echo .)com \
--cc=jon@solid-run$(echo .)com \
--cc=jun.li@nxp$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=l.stach@pengutronix$(echo .)de \
--cc=leonard.crestez@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=peng.fan@nxp$(echo .)com \
--cc=ping.bai@nxp$(echo .)com \
--cc=richard.hu@technexion$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=troy.kisky@boundarydevices$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox