From: Sakari Ailus <sakari.ailus@linux•intel.com>
To: Dongchun Zhu <dongchun.zhu@mediatek•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
drinkcat@chromium•org, srv_heupstream@mediatek•com,
shengnan.wang@mediatek•com,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
tfiga@chromium•org, louis.kuo@mediatek•com,
sj.huang@mediatek•com, robh+dt@kernel•org,
linux-mediatek@lists•infradead.org, matthias.bgg@gmail•com,
bingbu.cao@intel•com, mchehab@kernel•org,
linux-arm-kernel@lists•infradead.org,
linux-media@vger•kernel.org
Subject: Re: [V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor
Date: Wed, 30 Oct 2019 15:55:27 +0200 [thread overview]
Message-ID: <20191030135527.GH10211@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1572440653.21623.272.camel@mhfsdcap03>
On Wed, Oct 30, 2019 at 09:04:13PM +0800, Dongchun Zhu wrote:
> > > + ov8856->is_1B_revision = (val == OV8856_1B_MODULE) ? 1 : 0;
> >
> > !! will give same result without using ternary operator.
> >
>
> Fixed in next release.
But casting to bool will have the same effect. Integers are also not
needed. I.e. this can be written as:
ov8856->is_1B_revision = val == OV8856_1B_MODULE;
--
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-30 13:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <media: ov8856: DT bindings and sensor mode improvements>
2019-09-10 13:04 ` [V2, 0/2] media: ov8856: DT bindings and sensor mode improvements dongchun.zhu
2019-09-10 13:04 ` [V2, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856 dongchun.zhu
2019-09-10 17:37 ` Andy Shevchenko
2019-09-17 12:02 ` Sakari Ailus
2019-09-17 14:44 ` Rob Herring
2019-10-30 9:00 ` Dongchun Zhu
2019-10-30 9:08 ` Sakari Ailus
2019-09-10 13:04 ` [V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor dongchun.zhu
2019-09-10 17:44 ` Andy Shevchenko
2019-10-30 13:04 ` Dongchun Zhu
2019-10-30 13:55 ` Sakari Ailus [this message]
2019-09-11 10:12 ` Tomasz Figa
2019-09-11 11:43 ` Sakari Ailus
2019-09-13 7:55 ` Sakari Ailus
2019-10-30 13:02 ` Dongchun Zhu
2019-11-06 14:22 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030135527.GH10211@paasikivi.fi.intel.com \
--to=sakari.ailus@linux$(echo .)intel.com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=bingbu.cao@intel$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dongchun.zhu@mediatek$(echo .)com \
--cc=drinkcat@chromium$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=louis.kuo@mediatek$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=shengnan.wang@mediatek$(echo .)com \
--cc=sj.huang@mediatek$(echo .)com \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=tfiga@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox