From: Sakari Ailus <sakari.ailus@iki•fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
Cc: devicetree@vger•kernel.org, c.barrett@framos•com,
linux-kernel@vger•kernel.org, a.brela@framos•com,
peter.griffin@linaro•org, robh+dt@kernel•org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro•org>,
mchehab@kernel•org, linux-arm-kernel@lists•infradead.org,
linux-media@vger•kernel.org
Subject: Re: [PATCH v4 0/2] Add IMX296 CMOS image sensor support
Date: Thu, 31 Oct 2019 17:48:33 +0200 [thread overview]
Message-ID: <20191031154833.GM6253@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20191031132801.GC5018@pendragon.ideasonboard.com>
Hi Mani, Laurent,
On Thu, Oct 31, 2019 at 03:28:01PM +0200, Laurent Pinchart wrote:
> Hi Mani,
>
> On Thu, Oct 31, 2019 at 06:53:52PM +0530, Manivannan Sadhasivam wrote:
> > On Thu, Oct 31, 2019 at 03:16:44PM +0200, Laurent Pinchart wrote:
> > > On Wed, Oct 30, 2019 at 03:19:00PM +0530, Manivannan Sadhasivam wrote:
> > > > Hello,
> > > >
> > > > This patchset adds support for IMX296 CMOS image sensor from Sony.
> > > > Sensor can be programmed through I2C and 4-wire interface but the
> > > > current driver only supports I2C interface. The sensor is
> > > > capable of outputting frames in CSI2 format (1 Lane). In the case
> > > > of sensor resolution, driver only supports 1440x1088 at 30 FPS.
> > > >
> > > > The driver has been validated using Framos IMX296 module interfaced to
> > > > 96Boards Dragonboard410c.
> > >
> > > I've just been made aware of your work. I also worked on an IMX296
> > > sensor driver in parallel, which I will post to the list. My driver
> > > doesn't hardcode the resolution but computes register values at runtime,
> > > so I wonder if it could be a better option. I'll post it now.
> >
> > I'm fine with it. The reason the driver is simple in the first place is, that's
> > how my usual workflow is. Start small and build it big ;-)
> >
> > Anyway, I'm happy if your driver gets in.
>
> My driver sometimes has trouble finding the sensor at probe time, so
> I'll study and try your code too. It could be a problem specific to my
> platform (I'm testing on a custom i.MX7 board).
Based on this discussion I'll mark the second patch of the set obsolete in
Patchwork.
Laurent: please see my comments on the driver as well.
--
Kind regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-31 15:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 9:49 [PATCH v4 0/2] Add IMX296 CMOS image sensor support Manivannan Sadhasivam
2019-10-30 9:49 ` [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Manivannan Sadhasivam
2019-10-30 11:53 ` Sakari Ailus
2019-10-30 12:01 ` Manivannan Sadhasivam
2019-11-05 1:43 ` Rob Herring
2019-10-31 13:15 ` Laurent Pinchart
2019-10-31 13:45 ` Manivannan Sadhasivam
2019-10-31 14:11 ` Laurent Pinchart
2019-10-31 14:28 ` Sakari Ailus
2019-10-31 16:54 ` Laurent Pinchart
2019-10-31 17:08 ` Sakari Ailus
2019-11-04 19:02 ` Laurent Pinchart
2019-11-04 21:30 ` Sakari Ailus
2019-11-04 22:00 ` Laurent Pinchart
2019-10-31 14:58 ` Manivannan Sadhasivam
2019-10-30 9:49 ` [PATCH v4 2/2] media: i2c: Add IMX296 CMOS image sensor driver Manivannan Sadhasivam
2019-10-31 13:16 ` [PATCH v4 0/2] Add IMX296 CMOS image sensor support Laurent Pinchart
2019-10-31 13:23 ` Manivannan Sadhasivam
2019-10-31 13:28 ` Laurent Pinchart
2019-10-31 15:48 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031154833.GM6253@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki$(echo .)fi \
--cc=a.brela@framos$(echo .)com \
--cc=c.barrett@framos$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=manivannan.sadhasivam@linaro$(echo .)org \
--cc=mchehab@kernel$(echo .)org \
--cc=peter.griffin@linaro$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox