From: Mark Brown <broonie@kernel•org>
To: Suzuki K Poulose <suzuki.poulose@arm•com>
Cc: Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v7 3/4] arm64: Don't use KPTI where we have E0PD
Date: Thu, 7 Nov 2019 14:37:50 +0000 [thread overview]
Message-ID: <20191107143750.GG6159@sirena.co.uk> (raw)
In-Reply-To: <05bafb8a-9019-701c-f744-a8d014771b87@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1331 bytes --]
On Thu, Nov 07, 2019 at 12:01:10PM +0000, Suzuki K Poulose wrote:
> On 06/11/2019 13:00, Mark Brown wrote:
> > + /*
> > + * E0PD does a similar job to KPTI so can be used instead
> > + * where available.
> > + */
> > + if (IS_ENABLED(CONFIG_ARM64_E0PD)) {
> > + ftr = read_sysreg_s(SYS_ID_AA64MMFR2_EL1);
> I am trying to write down the rationale of checking this per-CPU.
> Given that this gets run on all individual CPUs, via unmap_kernel_at_el0()
> and the decision of choosing KPTI is affected by the lack of the E0PD feature
> when it is helpful, having CPU local check is fine. Also this gives us the
> advantage of choosing an nG mapping when the boot CPU indicates the need.
Well, it's mainly the fact that this runs really early on in boot before
the cpufeature code has fully initialized so as with the existing code
immediately below for identifying TX1 we can't rely on the cpufeature
code being done.
> > + if ((ftr >> ID_AA64MMFR2_E0PD_SHIFT) & 0xf)
> nit: You may use the existing helper :
> cpuid_feature_extract_unsigned_field(ftr, ID_AA64MMFR2_E0PD_SHIFT)
It's probably worth you going over the existing code and cleaning up
existing users, I copied this idiom from somewhere else.
I will note that we're on version 7 and nothing here has changed for
quite some time.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-07 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 13:00 [PATCH v7 0/4] E0PD support Mark Brown
2019-11-06 13:00 ` [PATCH v7 1/4] arm64: Add initial support for E0PD Mark Brown
2019-11-07 10:12 ` Suzuki K Poulose
2019-11-07 11:55 ` Mark Brown
2019-11-06 13:00 ` [PATCH v7 2/4] arm64: Factor out checks for KASLR in KPTI code into separate function Mark Brown
2019-11-06 13:00 ` [PATCH v7 3/4] arm64: Don't use KPTI where we have E0PD Mark Brown
2019-11-07 12:01 ` Suzuki K Poulose
2019-11-07 14:37 ` Mark Brown [this message]
2019-11-07 15:03 ` Suzuki K Poulose
2019-11-08 14:10 ` Mark Brown
2019-11-07 14:48 ` Mark Brown
2019-11-06 13:00 ` [PATCH v7 4/4] arm64: Use a variable to store non-global mappings decision Mark Brown
2019-11-07 11:11 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107143750.GG6159@sirena.co.uk \
--to=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox