public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel•org>
To: Catalin Marinas <catalin.marinas@arm•com>
Cc: Will Deacon <will@kernel•org>, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] arm64: kaslr: Print warning if KASLR is disabled due to lack of seed
Date: Fri, 8 Nov 2019 14:17:31 +0000	[thread overview]
Message-ID: <20191108141731.GA39034@sirena.co.uk> (raw)
In-Reply-To: <20191108133830.GB22834@arrakis.emea.arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]

On Fri, Nov 08, 2019 at 01:38:31PM +0000, Catalin Marinas wrote:
> On Thu, Nov 07, 2019 at 12:12:41PM +0000, Mark Brown wrote:

> >  	seed = get_kaslr_seed(fdt);
> > -	if (!seed)
> > +	if (!seed) {
> > +		pr_warn("No seed available for KASLR, disabling\n");
> >  		return 0;
> > +	}

> For some reason, this patch locks up the VM on TX2, stuck in a recursive
> fault. Too early for a printk?

I guess so - I was able to trigger this print without problems on my
system locally, not sure what configuration or system changes would make
the difference on TX2 but clearly there's at least some with issues.
That's annoying, I'll add an initcall to do the print instead.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2019-11-08 14:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 12:12 [PATCH] arm64: kaslr: Print warning if KASLR is disabled due to lack of seed Mark Brown
2019-11-08 13:38 ` Catalin Marinas
2019-11-08 14:14   ` Mark Rutland
2019-11-08 14:35     ` Mark Brown
2019-11-08 14:17   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191108141731.GA39034@sirena.co.uk \
    --to=broonie@kernel$(echo .)org \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=will@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox