From: Mark Brown <broonie@kernel•org>
To: Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>,
Mark Rutland <mark.rutland@arm•com>
Cc: linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2 2/2] arm64: kaslr: Check command line before looking for a seed
Date: Fri, 8 Nov 2019 15:50:05 +0000 [thread overview]
Message-ID: <20191108155005.GG5532@sirena.co.uk> (raw)
In-Reply-To: <20191108154607.51051-3-broonie@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 423 bytes --]
On Fri, Nov 08, 2019 at 03:46:07PM +0000, Mark Brown wrote:
> - /*
> - * Retrieve (and wipe) the seed from the FDT
> - */
> - seed = get_kaslr_seed(fdt);
> - if (!seed) {
> - kaslr_status = KASLR_DISABLED_NO_SEED;
> - return 0;
> - }
> -
Sorry, realized immediately after sending this that it would be better
to only move the if statement here in case the user has provided a seed
but also explicitly disabled KASLR.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-11-08 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 15:46 [PATCH v2 0/2] Improve KASLR diagnostics Mark Brown
2019-11-08 15:46 ` [PATCH v2 1/2] arm64: kaslr: Announce KASLR status on boot Mark Brown
2019-11-08 15:46 ` [PATCH v2 2/2] arm64: kaslr: Check command line before looking for a seed Mark Brown
2019-11-08 15:50 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108155005.GG5532@sirena.co.uk \
--to=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox