From: Jonathan Cameron <jic23@kernel•org>
To: Fabrice Gasnier <fabrice.gasnier@st•com>
Cc: lars@metafoo•de, alexandre.torgue@st•com,
linux-iio@vger•kernel.org, pmeerw@pmeerw•net,
linux-kernel@vger•kernel.org, mcoquelin.stm32@gmail•com,
knaack.h@gmx•de, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, benjamin.gaignard@st•com
Subject: Re: [PATCH] iio: trigger: stm32-timer: remove unnecessary update event
Date: Sat, 23 Nov 2019 16:43:30 +0000 [thread overview]
Message-ID: <20191123164330.04785b93@archlinux> (raw)
In-Reply-To: <1574334317-30014-1-git-send-email-fabrice.gasnier@st.com>
On Thu, 21 Nov 2019 12:05:17 +0100
Fabrice Gasnier <fabrice.gasnier@st•com> wrote:
> There is no need to explicitly generate update event to update
> timer master mode.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st•com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it
Thanks,
Jonathan
> ---
> drivers/iio/trigger/stm32-timer-trigger.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index a5dfe65..2e0d32a 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -297,9 +297,6 @@ static ssize_t stm32_tt_store_master_mode(struct device *dev,
> strlen(master_mode_table[i]))) {
> regmap_update_bits(priv->regmap, TIM_CR2, mask,
> i << shift);
> - /* Make sure that registers are updated */
> - regmap_update_bits(priv->regmap, TIM_EGR,
> - TIM_EGR_UG, TIM_EGR_UG);
> return len;
> }
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-11-23 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 11:05 [PATCH] iio: trigger: stm32-timer: remove unnecessary update event Fabrice Gasnier
2019-11-23 16:43 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191123164330.04785b93@archlinux \
--to=jic23@kernel$(echo .)org \
--cc=alexandre.torgue@st$(echo .)com \
--cc=benjamin.gaignard@st$(echo .)com \
--cc=fabrice.gasnier@st$(echo .)com \
--cc=knaack.h@gmx$(echo .)de \
--cc=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=pmeerw@pmeerw$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox