Subject: Re: [PATCH] ARM: dts: mvebu: add support for SolidRun Clearfog GTR

From: Andrew Lunn <[email-masked]>
Date: Fri, 29 Nov 2019 18:07:17 +0100

On Thu, Nov 28, 2019 at 07:00:06PM +0200, Baruch Siach wrote:
> SolidRun Clearfog GTR L8 and S4 SBCs are based on Armada 385. They
> features 8 (L8) or 4 (S4) switched Ethernet ports, 1 1Gb Ethernet port,
> 1 directly connected SFP port, 1 SFP port behind the switch (not
> currently described in DT),

Hi Baruch

Did you try to add the SFP on the switch? What problems did you have?
The general support for it should be there.

> +			i2c@11100 { /* SFP */
> +				pinctrl-0 = <&cf_gtr_i2c1_pins>;
> +				pinctrl-names = "default";
> +				status = "okay";
> +			};

Since there are two SFPs, it would be a good idea to indicate which
one this is.

> +	sfp: sfp {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&i2c1>;
> +		los-gpio = <&gpio1 22 GPIO_ACTIVE_HIGH>;
> +		mod-def0-gpio = <&gpio0 25 GPIO_ACTIVE_LOW>;
> +		tx-disable-gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>;
> +	};

when you get the second sfp working you are going to have naming
issue. So maybe call this sfp0?

> +		led1 {
> +			label = "led1";
> +			gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		led2 {
> +			label = "led2";
> +			gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>;
> +		};

There is a naming convention of LEDS labels. This does not fit it.

> +&gpio0 {
> +	pinctrl-0 = <&cf_gtr_fan_pwm>;
> +	pinctrl-names = "default";
> +
> +	wifi-disable {
> +		gpio-hog;
> +		gpios = <30 GPIO_ACTIVE_LOW>, <31 GPIO_ACTIVE_LOW>;
> +		output-low;
> +		line-name = "wifi-disable";
> +	};
> +};

Isn't there a generic rfkill GPIO driver? Never looked, but it seems
like it should exist.

> +	sar-isolation {
> +		gpio-hog;
> +		gpios = <15 GPIO_ACTIVE_LOW>;
> +		output-low;
> +		line-name = "sar-isolation";
> +	};

What is SAR?

     Andrew

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel