[PATCH v1 01/26] drm/drm_panel: no error when no callback

From: Sam Ravnborg <sam@ravnborg•org>
To: dri-devel@lists•freedesktop.org,
	Thierry Reding <thierry.reding@gmail•com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard•com>
Cc: Neil Armstrong <narmstrong@baylibre•com>,
	David Airlie <airlied@linux•ie>,
	Linus Walleij <linus.walleij@linaro•org>,
	Stefan Agner <stefan@agner•ch>,
	Andrzej Hajda <a.hajda@samsung•com>,
	Benjamin Gaignard <benjamin.gaignard@linaro•org>,
	Sam Ravnborg <sam@ravnborg•org>,
	linux-samsung-soc@vger•kernel.org,
	linux-rockchip@lists•infradead.org,
	Tomi Valkeinen <tomi.valkeinen@ti•com>,
	Jagan Teki <jagan@amarulasolutions•com>,
	NXP Linux Team <linux-imx@nxp•com>,
	Jitao Shi <jitao.shi@mediatek•com>,
	Pengutronix Kernel Team <kernel@pengutronix•de>,
	Maarten Lankhorst <maarten.lankhorst@linux•intel.com>,
	Maxime Ripard <mripard@kernel•org>,
	linux-mediatek@lists•infradead.org,
	Abhinav Kumar <abhinavk@codeaurora•org>,
	linux-tegra@vger•kernel.org, Sean Paul <sean@poorly•run>,
	linux-arm-kernel@lists•infradead.org,
	Purism Kernel Team <kernel@puri•sm>,
	linux-renesas-soc@vger•kernel.org,
	Boris Brezillon <boris.brezillon@collabora•com>,
	Daniel Vetter <daniel@ffwll•ch>
Subject: [PATCH v1 01/26] drm/drm_panel: no error when no callback
Date: Mon,  2 Dec 2019 20:32:05 +0100	[thread overview]
Message-ID: <20191202193230.21310-2-sam@ravnborg.org> (raw)
In-Reply-To: <20191202193230.21310-1-sam@ravnborg.org>

The callbacks in drm_panel_funcs are optional, so do not
return an error just because no callback is assigned.

Signed-off-by: Sam Ravnborg <sam@ravnborg•org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux•intel.com>
Cc: Maxime Ripard <mripard@kernel•org>
Cc: Thierry Reding <thierry.reding@gmail•com>
Cc: Sam Ravnborg <sam@ravnborg•org>
Cc: David Airlie <airlied@linux•ie>
Cc: Daniel Vetter <daniel@ffwll•ch>
---
 drivers/gpu/drm/drm_panel.c | 35 +++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index ed7985c0535a..2d59cdd05e50 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -151,10 +151,13 @@ EXPORT_SYMBOL(drm_panel_detach);
  */
 int drm_panel_prepare(struct drm_panel *panel)
 {
-	if (panel && panel->funcs && panel->funcs->prepare)
+	if (!panel)
+		return -EINVAL;
+
+	if (panel->funcs && panel->funcs->prepare)
 		return panel->funcs->prepare(panel);
 
-	return panel ? -ENOSYS : -EINVAL;
+	return 0;
 }
 EXPORT_SYMBOL(drm_panel_prepare);
 
@@ -171,10 +174,13 @@ EXPORT_SYMBOL(drm_panel_prepare);
  */
 int drm_panel_unprepare(struct drm_panel *panel)
 {
-	if (panel && panel->funcs && panel->funcs->unprepare)
+	if (!panel)
+		return -EINVAL;
+
+	if (panel->funcs && panel->funcs->unprepare)
 		return panel->funcs->unprepare(panel);
 
-	return panel ? -ENOSYS : -EINVAL;
+	return 0;
 }
 EXPORT_SYMBOL(drm_panel_unprepare);
 
@@ -190,10 +196,13 @@ EXPORT_SYMBOL(drm_panel_unprepare);
  */
 int drm_panel_enable(struct drm_panel *panel)
 {
-	if (panel && panel->funcs && panel->funcs->enable)
+	if (!panel)
+		return -EINVAL;
+
+	if (panel->funcs && panel->funcs->enable)
 		return panel->funcs->enable(panel);
 
-	return panel ? -ENOSYS : -EINVAL;
+	return 0;
 }
 EXPORT_SYMBOL(drm_panel_enable);
 
@@ -209,10 +218,13 @@ EXPORT_SYMBOL(drm_panel_enable);
  */
 int drm_panel_disable(struct drm_panel *panel)
 {
-	if (panel && panel->funcs && panel->funcs->disable)
+	if (!panel)
+		return -EINVAL;
+
+	if (panel->funcs && panel->funcs->disable)
 		return panel->funcs->disable(panel);
 
-	return panel ? -ENOSYS : -EINVAL;
+	return 0;
 }
 EXPORT_SYMBOL(drm_panel_disable);
 
@@ -228,10 +240,13 @@ EXPORT_SYMBOL(drm_panel_disable);
  */
 int drm_panel_get_modes(struct drm_panel *panel)
 {
-	if (panel && panel->funcs && panel->funcs->get_modes)
+	if (!panel)
+		return -EINVAL;
+
+	if (panel->funcs && panel->funcs->get_modes)
 		return panel->funcs->get_modes(panel);
 
-	return panel ? -ENOSYS : -EINVAL;
+	return 0;
 }
 EXPORT_SYMBOL(drm_panel_get_modes);
 
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
