From: Dan Carpenter <dan.carpenter@oracle•com>
To: Chuhong Yuan <hslester96@gmail•com>
Cc: devel@driverdev•osuosl.org,
Philipp Zabel <p.zabel@pengutronix•de>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
linux-kernel@vger•kernel.org, NXP Linux Team <linux-imx@nxp•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Steve Longerbeam <slongerbeam@gmail•com>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Shawn Guo <shawnguo@kernel•org>,
linux-arm-kernel@lists•infradead.org,
linux-media@vger•kernel.org
Subject: Re: [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove
Date: Thu, 12 Dec 2019 14:51:34 +0300 [thread overview]
Message-ID: <20191212115134.GA1895@kadam> (raw)
In-Reply-To: <20191209085828.16183-1-hslester96@gmail.com>
On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote:
> All drivers in imx call v4l2_async_notifier_cleanup() after unregistering
> the notifier except this driver.
> This should be a miss and we need to add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail•com>
> ---
> drivers/staging/media/imx/imx7-mipi-csis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
> index 99166afca071..2bfa85bb84e7 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -1105,6 +1105,7 @@ static int mipi_csis_remove(struct platform_device *pdev)
> mipi_csis_debugfs_exit(state);
> v4l2_async_unregister_subdev(&state->mipi_sd);
> v4l2_async_notifier_unregister(&state->subdev_notifier);
> + v4l2_async_notifier_cleanup(&state->subdev_notifier);
>
In this case the "state->subdev_notifier" was never initialized or used
so both v4l2_async_notifier_unregister() and v4l2_async_notifier_cleanup()
are no-ops.
We should just delete "subdev_notifier".
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-12 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 8:58 [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove Chuhong Yuan
2019-12-11 10:59 ` Rui Miguel Silva
2019-12-12 11:34 ` Hans Verkuil
2019-12-12 11:51 ` Dan Carpenter [this message]
2019-12-12 11:59 ` Philipp Zabel
2019-12-12 19:08 ` Rui Miguel Silva
2019-12-13 2:05 ` Steve Longerbeam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212115134.GA1895@kadam \
--to=dan.carpenter@oracle$(echo .)com \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hslester96@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=mchehab@kernel$(echo .)org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=slongerbeam@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox