Subject: Re: [PATCH] ARM:alignment:correct variable type of nr_regs

From: Russell King - ARM Linux admin <[email-masked]>
Date: Sun, 5 Jan 2020 14:00:14 +0000

On Sun, Jan 05, 2020 at 10:17:36AM +0800, [email-masked] wrote:
> From: hanter Liu <[email-masked]>
> 
> if ldmstm instruction U bit is unset, nr_regs
> should be negative value, so change variable
> type of nr_regs from unsigned int to int.
> 
> Signed-off-by: hanter Liu <[email-masked]>

Hi,

What observable bug is this fixing, or is this just a clean up? Please
clarify.

Thanks.

> ---
>  arch/arm/mm/alignment.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
> index 788c5cf..d8e3bd9 100644
> --- a/arch/arm/mm/alignment.c
> +++ b/arch/arm/mm/alignment.c
> @@ -499,7 +499,8 @@ do_alignment_ldrstr(unsigned long addr, u32 instr, struct pt_regs *regs)
>  static int
>  do_alignment_ldmstm(unsigned long addr, u32 instr, struct pt_regs *regs)
>  {
> -	unsigned int rd, rn, correction, nr_regs, regbits;
> +	int nr_regs;
> +	unsigned int rd, rn, correction, regbits;
>  	unsigned long eaddr, newaddr;
>  
>  	if (LDM_S_BIT(instr))
> -- 
> 2.7.4
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel