From: Jonathan Cameron <jic23@kernel•org>
To: Fabrice Gasnier <fabrice.gasnier@st•com>
Cc: etienne.carriere@st•com, lars@metafoo•de, olivier.moysan@st•com,
alexandre.torgue@st•com, linux-iio@vger•kernel.org,
pmeerw@pmeerw•net, linux-kernel@vger•kernel.org,
mcoquelin.stm32@gmail•com, knaack.h@gmx•de,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral
Date: Sat, 18 Jan 2020 14:22:12 +0000 [thread overview]
Message-ID: <20200118142212.55ea44fd@archlinux> (raw)
In-Reply-To: <1578921539-6353-1-git-send-email-fabrice.gasnier@st.com>
On Mon, 13 Jan 2020 14:18:59 +0100
Fabrice Gasnier <fabrice.gasnier@st•com> wrote:
> From: Etienne Carriere <etienne.carriere@st•com>
>
> Do not print an error trace when deferring probe for some resource.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@st•com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st•com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/stm32-adc-core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 97655d7..2df88d2 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -688,7 +688,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
> priv->vref = devm_regulator_get(&pdev->dev, "vref");
> if (IS_ERR(priv->vref)) {
> ret = PTR_ERR(priv->vref);
> - dev_err(&pdev->dev, "vref get failed, %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "vref get failed, %d\n", ret);
> return ret;
> }
>
> @@ -696,7 +697,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
> if (IS_ERR(priv->aclk)) {
> ret = PTR_ERR(priv->aclk);
> if (ret != -ENOENT) {
> - dev_err(&pdev->dev, "Can't get 'adc' clock\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Can't get 'adc' clock\n");
> return ret;
> }
> priv->aclk = NULL;
> @@ -706,7 +708,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
> if (IS_ERR(priv->bclk)) {
> ret = PTR_ERR(priv->bclk);
> if (ret != -ENOENT) {
> - dev_err(&pdev->dev, "Can't get 'bus' clock\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Can't get 'bus' clock\n");
> return ret;
> }
> priv->bclk = NULL;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-18 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 13:18 [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral Fabrice Gasnier
2020-01-18 14:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200118142212.55ea44fd@archlinux \
--to=jic23@kernel$(echo .)org \
--cc=alexandre.torgue@st$(echo .)com \
--cc=etienne.carriere@st$(echo .)com \
--cc=fabrice.gasnier@st$(echo .)com \
--cc=knaack.h@gmx$(echo .)de \
--cc=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=olivier.moysan@st$(echo .)com \
--cc=pmeerw@pmeerw$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox