From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: Matti Vaittinen <matti.vaittinen@fi•rohmeurope.com>
Cc: Andrew Lunn <andrew@lunn•ch>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
Heiko Stuebner <heiko@sntech•de>,
Geert Uytterhoeven <geert+renesas@glider•be>,
Neil Armstrong <narmstrong@baylibre•com>,
Linus Walleij <linus.walleij@linaro•org>,
Patrice Chotard <patrice.chotard@st•com>,
Paul Cercueil <paul@crapouillou•net>,
Eric Anholt <eric@anholt•net>,
linux-stm32@st-md-mailman•stormreply.com,
Alexandre Torgue <alexandre.torgue@st•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Gregory Clement <gregory.clement@bootlin•com>,
Chen-Yu Tsai <wens@csie•org>,
linux-rockchip@lists•infradead.org,
Ludovic Desroches <ludovic.desroches@microchip•com>,
Andy Gross <agross@kernel•org>,
bcm-kernel-feedback-list@broadcom•com,
linux-arm-msm@vger•kernel.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>,
Jason Cooper <jason@lakedaemon•net>,
mazziesaccount@gmail•com, Ray Jui <rjui@broadcom•com>,
linux-gpio@vger•kernel.org, linux-mediatek@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org,
Matthias Brugger <matthias.bgg@gmail•com>,
linux-arm-kernel@lists•infradead.org,
Scott Branden <sbranden@broadcom•com>,
Sean Wang <sean.wang@kernel•org>,
linux-kernel@vger•kernel.org, linux-renesas-soc@vger•kernel.org,
Stefan Wahren <wahrenst@gmx•net>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
linux-oxnas@groups•io
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Fri, 14 Feb 2020 21:35:17 -0800 [thread overview]
Message-ID: <20200215053517.GN955802@ripper> (raw)
In-Reply-To: <20191112141819.GA22076@localhost.localdomain>
On Tue 12 Nov 06:18 PST 2019, Matti Vaittinen wrote:
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 763da0be10d6..8844ca1261d5 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -485,8 +485,8 @@ static int msm_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
>
> val = msm_readl_ctl(pctrl, g);
>
> - /* 0 = output, 1 = input */
> - return val & BIT(g->oe_bit) ? 0 : 1;
> + return val & BIT(g->oe_bit) ? GPIO_LINE_DIRECTION_OUT :
> + GPIO_LINE_DIRECTION_IN;
For pinctrl-msm:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro•org>
> }
Regards,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-02-15 5:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:18 [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-12 17:01 ` Bjorn Andersson
2019-11-12 18:18 ` Geert Uytterhoeven
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:52 ` Vaittinen, Matti
2019-11-13 9:40 ` Linus Walleij
2019-11-13 9:53 ` Vaittinen, Matti
2019-11-13 10:06 ` Vaittinen, Matti
2019-11-13 17:18 ` Linus Walleij
2020-02-14 11:14 ` Vaittinen, Matti
2019-11-13 8:53 ` Jacopo Mondi
2020-02-15 5:35 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200215053517.GN955802@ripper \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=eric@anholt$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=jason@lakedaemon$(echo .)net \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-oxnas@groups$(echo .)io \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=ludovic.desroches@microchip$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=matti.vaittinen@fi$(echo .)rohmeurope.com \
--cc=mazziesaccount@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=patrice.chotard@st$(echo .)com \
--cc=paul@crapouillou$(echo .)net \
--cc=rjui@broadcom$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=sean.wang@kernel$(echo .)org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox