From: Jesper Dangaard Brouer <brouer@redhat•com>
To: Ilias Apalodimas <ilias.apalodimas@linaro•org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Jakub Kicinski <kuba@kernel•org>,
Alexandre Torgue <alexandre.torgue@st•com>,
Daniel Borkmann <daniel@iogearbox•net>,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
toke@redhat•com, John Fastabend <john.fastabend@gmail•com>,
brouer@redhat•com, Alexei Starovoitov <ast@kernel•org>,
Jassi Brar <jaswinder.singh@linaro•org>,
Jose Abreu <joabreu@synopsys•com>,
linux-arm-kernel@lists•infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
jonathan.lemon@gmail•com,
Giuseppe Cavallaro <peppe.cavallaro@st•com>,
bpf@vger•kernel.org, lorenzo@kernel•org,
"David S. Miller" <davem@davemloft•net>,
linux-kernel@vger•kernel.org,
Jesper Dangaard Brouer <hawk@kernel•org>
Subject: Re: [PATCH net-next v2] net: page_pool: API cleanup and comments
Date: Mon, 17 Feb 2020 08:41:33 +0100 [thread overview]
Message-ID: <20200217084133.1a67ae63@carbon> (raw)
In-Reply-To: <20200217062850.133121-1-ilias.apalodimas@linaro.org>
On Mon, 17 Feb 2020 08:28:49 +0200
Ilias Apalodimas <ilias.apalodimas@linaro•org> wrote:
> diff --git a/include/net/page_pool.h b/include/net/page_pool.h
> index cfbed00ba7ee..7c1f23930035 100644
> --- a/include/net/page_pool.h
> +++ b/include/net/page_pool.h
> @@ -162,39 +162,33 @@ static inline void page_pool_use_xdp_mem(struct page_pool *pool,
> }
> #endif
>
> -/* Never call this directly, use helpers below */
> -void __page_pool_put_page(struct page_pool *pool, struct page *page,
> - unsigned int dma_sync_size, bool allow_direct);
> +void page_pool_release_page(struct page_pool *pool, struct page *page);
>
> -static inline void page_pool_put_page(struct page_pool *pool,
> - struct page *page, bool allow_direct)
> +/* If the page refcnt == 1, this will try to recycle the page.
> + * if PP_FLAG_DMA_SYNC_DEV is set, it will try to sync the DMA area for
> + * the configured size min(dma_sync_size, pool->max_len).
> + * If the page refcnt != page will be returned
Is this last comment line fully formed?
> + */
> +void page_pool_put_page(struct page_pool *pool, struct page *page,
> + unsigned int dma_sync_size, bool allow_direct);
> +
> +/* Same as above but will try to sync the entire area pool->max_len */
> +static inline void page_pool_put_full_page(struct page_pool *pool,
> + struct page *page, bool allow_direct)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-17 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 6:28 [PATCH net-next v2] net: page_pool: API cleanup and comments Ilias Apalodimas
2020-02-17 7:41 ` Jesper Dangaard Brouer [this message]
2020-02-17 7:46 ` Ilias Apalodimas
2020-02-17 8:08 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217084133.1a67ae63@carbon \
--to=brouer@redhat$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=hawk@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=joabreu@synopsys$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=lorenzo@kernel$(echo .)org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=toke@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox